Skip to content

Conversation

@oxc-bot
Copy link
Contributor

@oxc-bot oxc-bot commented Feb 23, 2025

[0.15.12] - 2025-02-23

Features

Bug Fixes

Performance

Documentation

Refactor

Testing

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-editor Area - Editor and Language Server labels Feb 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2025

Oxlint Ecosystem CI

suite result
rolldown/rolldown
napi-rs/napi-rs
toeverything/affine
preactjs/preact
microsoft/vscode
calcom/cal.com
bbc/simorgh
sidebase/nuxt-auth
elastic/kibana
DefinitelyTyped/DefinitelyTyped
Milkdown/milkdown
bluesky-social/social-app
oven-sh/bun

@Boshen Boshen marked this pull request as draft February 23, 2025 13:54
@Boshen
Copy link
Member

Boshen commented Feb 23, 2025

By looking at outputs from https://github.com/oxc-project/oxlint-ecosystem-ci/actions/runs/13482933859/job/37670497333, we should mark indirect eval as safe (not turned on by default). Only direct eval should flag an error. cc @shulaoda

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 23, 2025

CodSpeed Performance Report

Merging #9300 will not alter performance

Comparing release/oxlint-1740318727 (edf5a48) with main (3031845)

Summary

✅ 33 untouched benchmarks

@shulaoda
Copy link
Member

shulaoda commented Feb 23, 2025

By looking at outputs from https://github.com/oxc-project/oxlint-ecosystem-ci/actions/runs/13482933859/job/37670497333, we should mark indirect eval as safe (not turned on by default). Only direct eval should flag an error. cc @shulaoda

The default behavior is like this, we can change it.

camchenry pushed a commit that referenced this pull request Feb 23, 2025
…l` (#9302)

Related to #9300

The behavior is inconsistent with `eslint`, we default to allowing
indirect `eval`.
@Boshen Boshen marked this pull request as ready for review February 23, 2025 23:25
@Boshen Boshen marked this pull request as draft February 23, 2025 23:26
@Boshen Boshen marked this pull request as ready for review February 24, 2025 07:41
@Boshen Boshen merged commit 6764b8d into main Feb 24, 2025
33 of 34 checks passed
@Boshen Boshen deleted the release/oxlint-1740318727 branch February 24, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-editor Area - Editor and Language Server A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants