Skip to content

test(linter): ensure CLI filters take precedence over nested configs #9156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Feb 22, 2025
Merged

test(linter): ensure CLI filters take precedence over nested configs #9156

graphite-app merged 1 commit into from
Feb 22, 2025

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Feb 16, 2025 •
edited
Loading

Adds some regression tests to ensure that filters like -D <rule> or -A <rule> will override whatever is loaded from a configuration file that is either automatically loaded as a nested config, or explicitly loaded from the --config option.

This was referenced Feb 16, 2025
Merged
Merged
@camchenry Graphite App
Copy link
Member Author

camchenry commented Feb 16, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camchenry camchenry mentioned this pull request Feb 16, 2025
Merged
@github-actions github-actions bot added A-cli Area - CLI C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Feb 16, 2025
@camchenry camchenry force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch 2 times, most recently from 68eabce to 979b3ab Compare February 17, 2025 02:11
@camchenry camchenry force-pushed the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch from f4a7d8f to ad7f677 Compare February 17, 2025 02:12
@camchenry camchenry marked this pull request as ready for review February 18, 2025 14:21
@camchenry camchenry mentioned this pull request Feb 19, 2025
Merged
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 20, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented Feb 20, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Feb 19, 9:26 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 22, 6:15 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 22, 6:21 PM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from 979b3ab to 12cf88c Compare February 20, 2025 02:47
@Boshen Boshen force-pushed the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch from ad7f677 to 3801f11 Compare February 20, 2025 02:47
@camchenry camchenry force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from 12cf88c to e0c6948 Compare February 22, 2025 04:43
@camchenry camchenry force-pushed the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch from 3801f11 to b29c336 Compare February 22, 2025 04:43
@camchenry camchenry force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from e0c6948 to d981385 Compare February 22, 2025 22:25
@camchenry camchenry force-pushed the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch from b29c336 to 28d9e68 Compare February 22, 2025 22:25
@camchenry camchenry force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from 06f4611 to 2c2a09e Compare February 22, 2025 22:34
@camchenry camchenry force-pushed the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch from 18eaaf5 to 653750a Compare February 22, 2025 22:34
@graphite-app graphite-app bot force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from 2c2a09e to 8083d66 Compare February 22, 2025 22:48
@graphite-app graphite-app bot force-pushed the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch from 653750a to 4667457 Compare February 22, 2025 22:49
@camchenry camchenry force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from 8083d66 to 165bd69 Compare February 22, 2025 23:09
@camchenry camchenry force-pushed the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch from 4667457 to cbbf941 Compare February 22, 2025 23:09
@camchenry
test(linter): ensure CLI filters take precedence over nested configs (#…
e49c92d 
…9156)

- part of #7408

Adds some regression tests to ensure that filters like `-D <rule>` or `-A <rule>` will override whatever is loaded from a configuration file that is either automatically loaded as a nested config, or explicitly loaded from the `--config` option.
@graphite-app graphite-app bot force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from 165bd69 to 4ed9d76 Compare February 22, 2025 23:15
@graphite-app graphite-app bot force-pushed the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch from cbbf941 to e49c92d Compare February 22, 2025 23:16
Base automatically changed from 02-15-fix_linter_do_not_use_nested_configs_with_--config_option to main February 22, 2025 23:20
@graphite-app graphite-app bot merged commit e49c92d into main Feb 22, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch February 22, 2025 23:21
@oxc-bot oxc-bot mentioned this pull request Feb 23, 2025
Merged
This was referenced Feb 23, 2025
Merged
Merged
Merged
Merged
Merged
@camchenry camchenry mentioned this pull request Mar 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

0-merge Merge with Graphite Merge Queue A-cli Area - CLI C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camchenry @Boshen