Skip to content

fix(linter): do not use nested configs with --config option #9155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Feb 22, 2025
Merged

fix(linter): do not use nested configs with --config option #9155

graphite-app merged 1 commit into from
Feb 22, 2025

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Feb 16, 2025 •
edited
Loading

Ensures that when a config file is explicitly passed via -c or --config, that file will take precedence over all nested config files, and we will not search for config files within any directories.

This was referenced Feb 16, 2025
Merged
Merged
@camchenry Graphite App
Copy link
Member Author

camchenry commented Feb 16, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camchenry camchenry mentioned this pull request Feb 16, 2025
Merged
@github-actions github-actions bot added A-cli Area - CLI C-bug Category - Bug labels Feb 16, 2025
@camchenry camchenry force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from 7d265be to 68eabce Compare February 17, 2025 02:11
@camchenry camchenry force-pushed the 02-15-feat_linter_add_support_for_nested_config_files branch from 19878f1 to cdbcf2b Compare February 17, 2025 02:11
@camchenry camchenry force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from 68eabce to 979b3ab Compare February 17, 2025 02:11
@camchenry camchenry marked this pull request as ready for review February 17, 2025 02:46
@camchenry camchenry mentioned this pull request Feb 19, 2025
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 20, 2025
@Boshen Boshen force-pushed the 02-15-feat_linter_add_support_for_nested_config_files branch 2 times, most recently from 9194935 to 20cdf87 Compare February 20, 2025 02:47
@Boshen Boshen force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from 979b3ab to 12cf88c Compare February 20, 2025 02:47
@camchenry camchenry force-pushed the 02-15-feat_linter_add_support_for_nested_config_files branch from 20cdf87 to 667768c Compare February 22, 2025 04:43
@camchenry camchenry force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from 12cf88c to e0c6948 Compare February 22, 2025 04:43
@camchenry camchenry force-pushed the 02-15-feat_linter_add_support_for_nested_config_files branch from 667768c to 2f94ba8 Compare February 22, 2025 22:25
@camchenry camchenry force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from e0c6948 to d981385 Compare February 22, 2025 22:25
@camchenry camchenry force-pushed the 02-15-feat_linter_add_support_for_nested_config_files branch from 92eaf4f to 1174024 Compare February 22, 2025 22:34
@camchenry camchenry force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from 06f4611 to 2c2a09e Compare February 22, 2025 22:34
@graphite-app graphite-app bot force-pushed the 02-15-feat_linter_add_support_for_nested_config_files branch from 1174024 to 9bc3017 Compare February 22, 2025 22:43
Base automatically changed from 02-15-feat_linter_add_support_for_nested_config_files to main February 22, 2025 22:48
@graphite-app graphite-app bot force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from 2c2a09e to 8083d66 Compare February 22, 2025 22:48
@camchenry camchenry force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from 8083d66 to 165bd69 Compare February 22, 2025 23:09
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 22, 2025 •
edited
Loading

Merge activity

@camchenry
fix(linter): do not use nested configs with --config option (#9155)
4ed9d76 
- part of #7408

Ensures that when a config file is explicitly passed via `-c` or `--config`, that file will take precedence over all nested config files, and we will not search for config files within any directories.
@graphite-app graphite-app bot force-pushed the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch from 165bd69 to 4ed9d76 Compare February 22, 2025 23:15
@graphite-app graphite-app bot merged commit 4ed9d76 into main Feb 22, 2025
15 checks passed
@graphite-app graphite-app bot deleted the 02-15-fix_linter_do_not_use_nested_configs_with_--config_option branch February 22, 2025 23:20
@oxc-bot oxc-bot mentioned this pull request Feb 23, 2025
Merged
This was referenced Feb 23, 2025
Merged
Merged
Merged
Merged
Merged
@camchenry camchenry mentioned this pull request Mar 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sysix Sysix Sysix approved these changes

Assignees

No one assigned

Labels

0-merge Merge with Graphite Merge Queue A-cli Area - CLI C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camchenry @Sysix