feat(linter): allow adding more overrides via `extends` configs #9475

camchenry · 2025-03-01T22:36:36Z

closes linter: Add support for extends keyword #9307

Implements basic support for appending to the overrides array via configuration files referenced with extends.

camchenry · 2025-03-01T22:36:59Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-03-01T22:45:58Z

CodSpeed Performance Report

Merging #9475 will create unknown performance changes

_{Comparing 03-01-feat_linter_allow_adding_more_overrides_via_extends_configs (41f32ea) with main (fb7cf10)}

Summary

🆕 33 new benchmarks

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
🆕	`codegen[checker.ts]`	N/A	23.1 ms	N/A
🆕	`codegen_sourcemap[checker.ts]`	N/A	66.2 ms	N/A
🆕	`isolated-declarations[vue-id.ts]`	N/A	57.8 ms	N/A
🆕	`lexer[RadixUIAdoptionSection.jsx]`	N/A	20.8 µs	N/A
🆕	`lexer[antd.js]`	N/A	24.1 ms	N/A
🆕	`lexer[cal.com.tsx]`	N/A	5.7 ms	N/A
🆕	`lexer[checker.ts]`	N/A	14.5 ms	N/A
🆕	`lexer[pdf.mjs]`	N/A	3.8 ms	N/A
🆕	`linter[RadixUIAdoptionSection.jsx]`	N/A	2.7 ms	N/A
🆕	`linter[cal.com.tsx]`	N/A	1.2 s	N/A
🆕	`linter[checker.ts]`	N/A	2.9 s	N/A
🆕	`mangler[antd.js]`	N/A	16.1 ms	N/A
🆕	`mangler[react.development.js]`	N/A	296.5 µs	N/A
🆕	`mangler[typescript.js]`	N/A	39.8 ms	N/A
🆕	`minifier[antd.js]`	N/A	163 ms	N/A
🆕	`minifier[react.development.js]`	N/A	1.8 ms	N/A
🆕	`minifier[typescript.js]`	N/A	285.8 ms	N/A
🆕	`estree[checker.ts]`	N/A	91.8 ms	N/A
🆕	`parser[RadixUIAdoptionSection.jsx]`	N/A	88.9 µs	N/A
🆕	`parser[antd.js]`	N/A	111.9 ms	N/A
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

crates/oxc_linter/src/config/config_builder.rs

graphite-app · 2025-03-04T03:54:19Z

Merge activity

Mar 3, 10:54 PM EST: A user added this pull request to the Graphite merge queue.
Mar 3, 11:02 PM EST: A user merged this pull request with the Graphite merge queue.

- closes #9307 Implements basic support for appending to the `overrides` array via configuration files referenced with `extends`.

## [0.15.14] - 2025-03-11 ### Features - 0815fe8 linter: Add `promise/no-return-wrap` (#9537) (therewillbecode) - ae7bb75 linter: Add react/jsx-filename-extension rule (#9474) (Cédric DIRAND) - 50327f3 linter: Add import/exports-last (#9578) (yefan) - 75e4b8d linter: Add import/no-anonymous-default-export rule (#9481) (yefan) - 2f08b16 linter: Add `promise/prefer-catch` (#9488) (therewillbecode) - 41f32ea linter: Allow adding more overrides via `extends` configs (#9475) (camchenry) - fb7cf10 linter: Allowing `plugins` to be extended with `extends` (#9473) (camchenry) - fc74849 linter: Inherit `rules` via the extended config files (#9308) (camchenry) - 3fce826 linter: Add support for `extends` property in oxlintrc (#9217) (camchenry) ### Bug Fixes - 2d42569 linter: Rule `eslint/no-unsafe-optional-chaining` (#9632) (therewillbecode) - a9d7df9 linter: False positive in `unicorn/escape-case` (#9638) (shulaoda) - 3831819 linter: Fix example lint declaration and macro syntax (#9626) (Uli) - 4ca62ab linter: Output right file line and column for `.vue`, `.astro` and `.svelte` files (#9484) (Sysix) - 3105159 linter: Do not output number of rules with nested configs (#9476) (camchenry) - 5ecda01 linter: Support nested extending (#9472) (camchenry) ### Documentation - b7c61e9 linter: Improve docs for `eslint-guard-for-in` (#9658) (therewillbecode) - 1cc43f7 linter: Improve the documentation of `eslint-no-console` (#9612) (therewillbecode) - 608bb77 linter: Improve the docs and add test case for `typescript-no-extra-non-null-assertion` (#9609) (therewillbecode) - 43add5d linter: Better docs for `typescript-no-non-null-asserted-nullish-coalescing` rule (#9610) (therewillbecode) - bd90ce6 linter: Improve the docs and add test cases for `eslint-no-shadow-restricted-names` (#9597) (therewillbecode) - a0c9f7c linter: Improve the documentation of `eslint-no-func-assign` (#9596) (therewillbecode) - ec922e9 linter: Improve the documentation of `typescript-consistent-type-definitions` (#9575) (therewillbecode) - 165c89d linter: Improve the documentation of `typescript-no-namespace` (#9545) (therewillbecode) ### Refactor - c174600 linter: Improve `eslint/no-duplicate-imports` (#9627) (therewillbecode) - 31ba425 linter: Improve `eslint/no-self-assign` (#9635) (therewillbecode) - 03a40df linter: Access scoping from `ctx` directly (#9624) (Boshen) - be5e5dc linter: Improve `unicorn/escape-case` (#9568) (shulaoda) - b7f82fc linter: Improve `unicorn/error-message` (#9560) (shulaoda) - 069ef2d linter: Improve `promise/no-nesting` (#9544) (therewillbecode) - 62bffed rust: Allow a few annoying clippy rules (#9588) (Boshen) ### Testing - 934a387 linter: Remove test dependency on oxlint (#9513) (camchenry) Co-authored-by: Boshen <[email protected]>

camchenry mentioned this pull request Mar 1, 2025

feat(linter): allowing plugins to be extended with extends #9473

Merged

github-actions bot added A-linter Area - Linter A-cli Area - CLI C-enhancement Category - New feature or request labels Mar 1, 2025

camchenry mentioned this pull request Mar 1, 2025

fix(linter): do not output number of rules with nested configs #9476

Merged

camchenry force-pushed the 03-01-feat_linter_allowing_plugins_to_be_extended_with_extends_ branch from e664bb9 to a15b862 Compare March 1, 2025 22:51

camchenry force-pushed the 03-01-feat_linter_allow_adding_more_overrides_via_extends_configs branch from 46b5f2f to c649380 Compare March 1, 2025 22:51

camchenry marked this pull request as ready for review March 1, 2025 22:53

shulaoda approved these changes Mar 2, 2025

View reviewed changes

Sysix reviewed Mar 2, 2025

View reviewed changes

crates/oxc_linter/src/config/config_builder.rs Outdated Show resolved Hide resolved

camchenry mentioned this pull request Mar 3, 2025

test(linter): remove test dependency on oxlint #9513

Merged

camchenry force-pushed the 03-01-feat_linter_allowing_plugins_to_be_extended_with_extends_ branch from a15b862 to 146d9fb Compare March 3, 2025 18:45

camchenry force-pushed the 03-01-feat_linter_allow_adding_more_overrides_via_extends_configs branch from c649380 to e0899c3 Compare March 3, 2025 18:50

camchenry force-pushed the 03-01-feat_linter_allowing_plugins_to_be_extended_with_extends_ branch from 146d9fb to 62632b4 Compare March 4, 2025 02:58

camchenry force-pushed the 03-01-feat_linter_allow_adding_more_overrides_via_extends_configs branch from e0899c3 to bf63a27 Compare March 4, 2025 02:58

camchenry force-pushed the 03-01-feat_linter_allowing_plugins_to_be_extended_with_extends_ branch 2 times, most recently from d883822 to 95c5eaf Compare March 4, 2025 03:43

camchenry force-pushed the 03-01-feat_linter_allow_adding_more_overrides_via_extends_configs branch 2 times, most recently from 489e3d3 to 0e5a0de Compare March 4, 2025 03:44

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 4, 2025

feat(linter): allow adding more overrides via extends configs (#9475)

41f32ea

- closes #9307 Implements basic support for appending to the `overrides` array via configuration files referenced with `extends`.

graphite-app bot force-pushed the 03-01-feat_linter_allowing_plugins_to_be_extended_with_extends_ branch from 95c5eaf to fb7cf10 Compare March 4, 2025 03:54

graphite-app bot force-pushed the 03-01-feat_linter_allow_adding_more_overrides_via_extends_configs branch from 0e5a0de to 41f32ea Compare March 4, 2025 03:55

Base automatically changed from 03-01-feat_linter_allowing_plugins_to_be_extended_with_extends_ to main March 4, 2025 04:00

graphite-app bot merged commit 41f32ea into main Mar 4, 2025
26 checks passed

graphite-app bot deleted the 03-01-feat_linter_allow_adding_more_overrides_via_extends_configs branch March 4, 2025 04:02

camchenry mentioned this pull request Mar 10, 2025

linter: Add support for extends keyword #9307

Closed

3 tasks

oxc-bot mentioned this pull request Mar 11, 2025

release(oxlint): v0.15.14 #9681

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(linter): allow adding more overrides via `extends` configs #9475

feat(linter): allow adding more overrides via `extends` configs #9475

Uh oh!

camchenry commented Mar 1, 2025 •

edited

Loading

Uh oh!

camchenry commented Mar 1, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

graphite-app bot commented Mar 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

feat(linter): allow adding more overrides via extends configs #9475

feat(linter): allow adding more overrides via extends configs #9475

Uh oh!

Conversation

camchenry commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camchenry commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #9475 will create unknown performance changes

Summary

Benchmarks breakdown

Uh oh!

Uh oh!

graphite-app bot commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(linter): allow adding more overrides via `extends` configs #9475

feat(linter): allow adding more overrides via `extends` configs #9475

camchenry commented Mar 1, 2025 •

edited

Loading

camchenry commented Mar 1, 2025 •

edited

Loading

codspeed-hq bot commented Mar 1, 2025 •

edited

Loading

graphite-app bot commented Mar 4, 2025 •

edited

Loading