fix(ast/extree): fix TSModuleDeclaration.global

[hi-ogawa]

spec: https://github.com/typescript-eslint/typescript-eslint/blob/6428670b94de0027189803e5a291858d2e45362d/packages/ast-spec/src/declaration/TSModuleDeclaration/spec.ts#L26-L36

It looks like this is a deprecated property as its redundant. I thought of removing it in https://github.com/oxc-project/acorn-test262, but that means I need to modify 10K files there, so I went with fixing this side.

[hi-ogawa]

• fix(ast/estree): fix Function.this_param #9913
• fix(ast/extree): fix TSModuleDeclaration.global #9907 👈 (View in Graphite)
• fix(ast/estree): fix BindingIdentifier #9822
• fix(ast/extree): fix Class.implements #9817
• fix(parser)!: rename type_parameters to type_arguments where needed  #9815
• test(ast/estree): update acorn-test262 #9816
• test(ast/estree): ignore field order difference from typescript-eslint #9813
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #9907 will create unknown performance changes

_{Comparing 03-20-fix_ast_extree_fix_tsmoduledeclaration.global_ (7c1cb2d) with 03-17-fix_ast_estree_fix_class.id_ (00642cd)}

Summary

🆕 33 new benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
🆕	codegen[checker.ts]	N/A	22.6 ms	N/A
🆕	codegen_sourcemap[checker.ts]	N/A	65.7 ms	N/A
🆕	isolated-declarations[vue-id.ts]	N/A	57.8 ms	N/A
🆕	lexer[RadixUIAdoptionSection.jsx]	N/A	20.7 µs	N/A
🆕	lexer[antd.js]	N/A	24.1 ms	N/A
🆕	lexer[cal.com.tsx]	N/A	5.7 ms	N/A
🆕	lexer[checker.ts]	N/A	14.5 ms	N/A
🆕	lexer[pdf.mjs]	N/A	3.8 ms	N/A
🆕	linter[RadixUIAdoptionSection.jsx]	N/A	2.7 ms	N/A
🆕	linter[cal.com.tsx]	N/A	1.2 s	N/A
🆕	linter[checker.ts]	N/A	3 s	N/A
🆕	mangler[antd.js]	N/A	15.8 ms	N/A
🆕	mangler[react.development.js]	N/A	292.2 µs	N/A
🆕	mangler[typescript.js]	N/A	39.4 ms	N/A
🆕	minifier[antd.js]	N/A	163.6 ms	N/A
🆕	minifier[react.development.js]	N/A	1.8 ms	N/A
🆕	minifier[typescript.js]	N/A	288.3 ms	N/A
🆕	estree[checker.ts]	N/A	96.8 ms	N/A
🆕	parser[RadixUIAdoptionSection.jsx]	N/A	90.9 µs	N/A
🆕	parser[antd.js]	N/A	112.3 ms	N/A
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

[overlookmotel]

I think the way you've done it here is good. Even if the field is deprecated, it still exists in TS-ESLint AST, and some code may rely on it. So we should match that.

[overlookmotel]

Merge activity

• Mar 21, 1:57 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 21, 1:57 AM EDT: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
• Mar 21, 1:57 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 21, 2:23 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

[overlookmotel]

You going to merge this or what, Mr Graphite?

[overlookmotel]

Graphite got stuck. I've merged manually.