Skip to content

Better behaviour in the presence of 429s #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamdanfox merged 30 commits into from
Sep 13, 2018
Merged

Better behaviour in the presence of 429s #786

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
2dcd409
Better behaviour in the presence of backing off
j-baker Aug 2, 2018
c583b33
Merge branch 'develop' into jbaker/better_429_behaviour
j-baker Aug 2, 2018
d51d3ac
more docs, easier to read
j-baker Aug 2, 2018
19a8173
Better concurrency limiters
j-baker Aug 3, 2018
d7164de
fixes
j-baker Aug 3, 2018
39388b7
simplify
j-baker Aug 3, 2018
f2927d0
Checkstyle
j-baker Aug 13, 2018
8f57de6
checkstyle
j-baker Aug 13, 2018
8f02b8b
PR comments
j-baker Sep 2, 2018
fbbcc41
Tweak the concurrency limiters lib
j-baker Sep 2, 2018
27a2153
reset flow control test
j-baker Sep 2, 2018
e548996
changes
j-baker Sep 2, 2018
a4c9e68
Changes
j-baker Sep 2, 2018
c68bc89
Passes the build
j-baker Sep 2, 2018
91dd6d2
update lockfiles
j-baker Sep 2, 2018
2229a81
Merge remote-tracking branch 'origin/develop' into jbaker/better_429_…
j-baker Sep 11, 2018
ee8e539
New attempt using interceptor
j-baker Sep 11, 2018
036d45b
more comments
j-baker Sep 11, 2018
1e18435
some bullshit
j-baker Sep 12, 2018
fbdeab1
Perfect
j-baker Sep 12, 2018
951dfdd
cleanup
j-baker Sep 12, 2018
ed18c48
Ready to go?
j-baker Sep 13, 2018
fda4d64
docs
j-baker Sep 13, 2018
8a088d7
Checkstyle
j-baker Sep 13, 2018
a9721e4
chekcstyle
j-baker Sep 13, 2018
1ce7b82
Metric
j-baker Sep 13, 2018
bc38b76
Javadoc
iamdanfox Sep 13, 2018
addbdca
README describes new flow control
iamdanfox Sep 13, 2018
c97925a
Move docs -> class level javadoc
iamdanfox Sep 13, 2018
baaa142
Rename ConcurrencyLimiters#limiter -> acquireLimiter
iamdanfox Sep 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'develop' into jbaker/better_429_behaviour
  • Loading branch information
@j-baker
j-baker committed Aug 2, 2018
commit c583b33fc539ba88edcbb5bd6a1c339b5fe4206f
6 changes: 4 additions & 2 deletions okhttp-clients/src/main/java/com/palantir/remoting3/okhttp/RemotingOkHttpCall.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,8 @@ public void onFailure(Call call, IOException exception) {
.build();
RemotingOkHttpCall retryCall =
client.newCallWithMutableState(redirectedRequest, backoffStrategy, maxNumRelocations - 1);
log.debug("Rescheduling call after backoff", SafeArg.of("backoffMillis", backoff.get().toMillis()));
log.debug("Rescheduling call after backoff", SafeArg.of("backoffMillis", backoff.get().toMillis()),
exception);
scheduleExecution(() -> {
listener.onDropped();
retryCall.enqueue(callback);
Expand Down Expand Up @@ -271,7 +272,8 @@ public Void visit(QosException.Throttle exception) {
}

Duration backoff = exception.getRetryAfter().orElse(nonAdvertizedBackoff.get());
Copy link
Contributor

@uschi2000 uschi2000 Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

difficult to grok what the interplay is between the Limiter and the backoffStrategy. they seem duplicative.

Copy link
Contributor Author

@j-baker j-baker Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and yet, they are not :)

Copy link
Contributor

@uschi2000 uschi2000 Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly

log.debug("Rescheduling call after backoff", SafeArg.of("backoffMillis", backoff.toMillis()));
log.debug("Rescheduling call after backoff",
SafeArg.of("backoffMillis", backoff.toMillis()), exception);
scheduleExecution(() -> {
listener.onDropped();
doClone().enqueue(callback);
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.