-
Notifications
You must be signed in to change notification settings - Fork 95
Better behaviour in the presence of 429s #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
2dcd409
Better behaviour in the presence of backing off
j-baker c583b33
Merge branch 'develop' into jbaker/better_429_behaviour
j-baker d51d3ac
more docs, easier to read
j-baker 19a8173
Better concurrency limiters
j-baker d7164de
fixes
j-baker 39388b7
simplify
j-baker f2927d0
Checkstyle
j-baker 8f57de6
checkstyle
j-baker 8f02b8b
PR comments
j-baker fbbcc41
Tweak the concurrency limiters lib
j-baker 27a2153
reset flow control test
j-baker e548996
changes
j-baker a4c9e68
Changes
j-baker c68bc89
Passes the build
j-baker 91dd6d2
update lockfiles
j-baker 2229a81
Merge remote-tracking branch 'origin/develop' into jbaker/better_429_…
j-baker ee8e539
New attempt using interceptor
j-baker 036d45b
more comments
j-baker 1e18435
some bullshit
j-baker fbdeab1
Perfect
j-baker 951dfdd
cleanup
j-baker ed18c48
Ready to go?
j-baker fda4d64
docs
j-baker 8a088d7
Checkstyle
j-baker a9721e4
chekcstyle
j-baker 1ce7b82
Metric
j-baker bc38b76
Javadoc
iamdanfox addbdca
README describes new flow control
iamdanfox c97925a
Move docs -> class level javadoc
iamdanfox baaa142
Rename ConcurrencyLimiters#limiter -> acquireLimiter
iamdanfox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
docs
- Loading branch information
commit fda4d647e4b6e3b75c33905f30cdedaef99aed95
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be more visible; the last sentence on a package-private class is not exactly discoverable. Perhaps javadoc on
RetrofitClient.create(since that's the clients we use for streaming, I believe?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just put a section about this in the README too