Better behaviour in the presence of 429s #786
fixes
- Loading branch information
commit d7164dec5e7ea66daff39a656646b609997cae38
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,156 @@ | ||
| /* | ||
| * Copyright 2018 Palantir Technologies, Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.palantir.remoting3.okhttp; | ||
|
|
||
| import com.codahale.metrics.Meter; | ||
| import com.google.common.util.concurrent.Futures; | ||
| import com.google.common.util.concurrent.ListenableFuture; | ||
| import com.google.common.util.concurrent.ListeningExecutorService; | ||
| import com.google.common.util.concurrent.MoreExecutors; | ||
| import com.google.common.util.concurrent.RateLimiter; | ||
| import com.netflix.concurrency.limits.Limiter; | ||
| import com.palantir.remoting3.okhttp.ConcurrencyLimiters.ConcurrencyLimiter; | ||
| import java.time.Duration; | ||
| import java.util.List; | ||
| import java.util.Optional; | ||
| import java.util.UUID; | ||
| import java.util.concurrent.ExecutionException; | ||
| import java.util.concurrent.Executors; | ||
| import java.util.concurrent.ThreadLocalRandom; | ||
| import java.util.function.Supplier; | ||
| import java.util.stream.Collectors; | ||
| import java.util.stream.IntStream; | ||
| import java.util.stream.Stream; | ||
| import org.junit.AfterClass; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.Test; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** | ||
| * This class is a simulation of the flow control primitives used by this library, in order to allow the developer | ||
| * to try different strategies. | ||
| * <p> | ||
| * It is run in CI, but only to prevent code breakages - this is in general a | ||
| */ | ||
| public final class FlowControlTest { | ||
| private static final Logger log = LoggerFactory.getLogger(FlowControlTest.class); | ||
| private static final int REQUESTS_PER_THREAD = System.getenv("CI") == null ? 1000 : 1; | ||
| private static final ConcurrencyLimiters limiters = new ConcurrencyLimiters(); | ||
| private static ListeningExecutorService executorService; | ||
|
|
||
| private final ConcurrencyLimiter limiter = limiters.limiter(UUID.randomUUID().toString()); | ||
|
|
||
| @BeforeClass | ||
| public static void beforeClass() { | ||
| executorService = MoreExecutors.listeningDecorator(Executors.newCachedThreadPool()); | ||
| } | ||
|
|
||
| @AfterClass | ||
| public static void afterClass() { | ||
| executorService.shutdown(); | ||
| } | ||
|
|
||
| @Test | ||
| public void test16ThreadsRateLimit20() throws ExecutionException, InterruptedException { | ||
| Meter rate = new Meter(); | ||
| List<ListenableFuture<?>> tasks = createWorkers(rate, 16, 20, Duration.ofMillis(100)) | ||
|
||
| .map(executorService::submit) | ||
| .collect(Collectors.toList()); | ||
| ListenableFuture<?> task = Futures.allAsList(tasks); | ||
| while (!task.isDone()) { | ||
| sleep(1000); | ||
| log.info("Average rate is {}, 1 minute rate is {}", rate.getMeanRate(), rate.getOneMinuteRate()); | ||
|
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment. It's actually kinda interesting, you don't expect to necessarily get that close to the maximum. Basically if the target concurrency rate is small enough, it won't be able to compensate right. So for example in this case, you basically cycle between: 1 thread, 10 requests a second. and you basically end up at about 16, overall. |
||
| } | ||
| task.get(); | ||
| } | ||
|
|
||
| private Stream<Worker> createWorkers(Meter rate, int numThreads, int rateLimit, Duration delay) { | ||
| RateLimiter rateLimiter = RateLimiter.create(rateLimit); | ||
| return IntStream.range(0, numThreads) | ||
| .mapToObj(unused -> new Worker( | ||
| () -> new ExponentialBackoff(4, Duration.ofMillis(250), ThreadLocalRandom.current()), | ||
| limiter, | ||
| delay, | ||
| rateLimiter, | ||
| rate)); | ||
| } | ||
|
|
||
| private static class Worker implements Runnable { | ||
| private final Supplier<BackoffStrategy> backoffFactory; | ||
| private final ConcurrencyLimiter limiter; | ||
| private final Duration successDuration; | ||
| private final RateLimiter rateLimiter; | ||
| private final Meter meter; | ||
|
|
||
| private BackoffStrategy backoff; | ||
|
|
||
| private Worker( | ||
| Supplier<BackoffStrategy> backoffFactory, | ||
| ConcurrencyLimiter limiter, | ||
| Duration successDuration, | ||
| RateLimiter rateLimiter, | ||
| Meter meter) { | ||
| this.backoffFactory = backoffFactory; | ||
| this.limiter = limiter; | ||
| this.successDuration = successDuration; | ||
| this.rateLimiter = rateLimiter; | ||
| this.meter = meter; | ||
| } | ||
|
|
||
| @Override | ||
| public void run() { | ||
| for (int i = 0; i < REQUESTS_PER_THREAD;) { | ||
| Limiter.Listener listener = Futures.getUnchecked(limiter.acquire()); | ||
| boolean gotRateLimited = !rateLimiter.tryAcquire(); | ||
| if (!gotRateLimited) { | ||
| meter.mark(); | ||
| sleep(successDuration.toMillis()); | ||
| listener.onSuccess(); | ||
| backoff = null; | ||
| i++; | ||
| } else { | ||
| initializeBackoff(); | ||
| Optional<Duration> sleep = backoff.nextBackoff(); | ||
| if (!sleep.isPresent()) { | ||
| listener.onIgnore(); | ||
| throw new RuntimeException("Failed on request " + i); | ||
| } else { | ||
| sleep(sleep.get().toMillis()); | ||
| } | ||
| listener.onDropped(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private void initializeBackoff() { | ||
j-baker marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if (backoff != null) { | ||
| return; | ||
| } | ||
| backoff = backoffFactory.get(); | ||
| } | ||
| } | ||
|
|
||
| private static void sleep(long duration) { | ||
| try { | ||
| Thread.sleep(duration); | ||
| } catch (InterruptedException e) { | ||
| Thread.currentThread().interrupt(); | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"...in general a"?