pchain_network v0.5 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd heartbeat interval
WIP: Refactor pchain network engine
…ssage deserialization
… Defined Error type for Engine
…mailbox topics from tests
Tests/refactor
Summary of review meeting (Oct 18, 2023)
|
…ons to conversions
Merged changes raised during meeting
manngayin612
commented
Oct 31, 2023
| Multiaddr, | ||
| }; | ||
| use pchain_types::cryptography::PublicAddress; | ||
| use pchain_types::cryptography::{PublicAddress, self}; |
There was a problem hiding this comment.
just import Keypair here instead of doing self here and qualify it as crytography::Keypair
manngayin612
commented
Oct 31, 2023
src/lib.rs
Outdated
| //! use crate::Config; | ||
| //! use crate::message_gate::MessageGateChain; | ||
| //! | ||
| //! use crate::peer::Peer; |
There was a problem hiding this comment.
use crate::Peer;
manngayin612
commented
Oct 31, 2023
| pub(crate) mod constants; | ||
|
|
||
| pub(crate) mod conversions; | ||
| pub mod peer; |
There was a problem hiding this comment.
add pub use peer::Peer
manngayin612
commented
Oct 31, 2023
| //! keypair: pchain_types::cryptography::Keypair, | ||
| //! topics_to_subscribe: vec![Topic::HotStuffRsBroadcast], | ||
| //! listening_port: 25519, | ||
| //! boot_nodes: vec![], |
There was a problem hiding this comment.
better to show format of boot_nodes here too
… true in gossipsub
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version in refactor branch is a refactor based on the comments and suggested structure that can be found it in here.