Convert Controller, Frameloop and target files to TypeScript #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated element and not included in ReactHTML TypeScript types. If we want to keep it, we can instead add it to ReactHTML in @types/react.
Still lots of any and dubious types
|
This pull request fixes 10 alerts when merging c651c2b into 74b0984 - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
|
i think removing marquee is fine. is this good to go? |
szjemljanoj
pushed a commit
to szjemljanoj/react-spring
that referenced
this pull request
Mar 29, 2019
Convert Controller, Frameloop and target files to TypeScript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controller types are pretty low quality still, but I need to get the entire code base to TypeScript to start experimenting with https://github.com/Swatinem/rollup-plugin-dts and other solutions to get output a type bundle.
There is a breaking change here in that
animated.marqueeis removed, because it is not recognized as a JSX element and thus not compatible withReactType. We can eitherJSXElements+marquee...