Skip to content

Convert Controller, Frameloop and target files to TypeScript #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 20, 2019
Merged

Convert Controller, Frameloop and target files to TypeScript #558

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
428f395
Convert target index files to TypeScript
jacobrask Feb 12, 2019
99bfda1
Remove animated.marquee
jacobrask Feb 12, 2019
767d601
Convert FrameLoop to TypeScript
jacobrask Feb 13, 2019
9a385d7
Move Controller test to live next to implementation
jacobrask Feb 13, 2019
636dfaa
Convert Controller to TypeScript
jacobrask Feb 17, 2019
c38f265
Add the SpringValue interface
jacobrask Feb 18, 2019
c651c2b
Remove unused argument from Controller constructor
jacobrask Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Convert FrameLoop to TypeScript
  • Loading branch information
@jacobrask
jacobrask committed Feb 19, 2019
commit 767d601dbbc8e0abfbf49430c30925d24de110a9
7 changes: 3 additions & 4 deletions src/animated/FrameLoop.js → src/animated/FrameLoop.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Animated from './Animated'
import Controller from './Controller'
import { now, requestFrame } from './Globals'

let active = false
Expand All @@ -15,7 +16,7 @@ const frameLoop = () => {
configIdx++
) {
let config = controller.configs[configIdx]
let endOfAnimation, lastTime, velocity
let endOfAnimation, lastTime
for (let valIdx = 0; valIdx < config.animatedValues.length; valIdx++) {
let animation = config.animatedValues[valIdx]

Expand Down Expand Up @@ -129,14 +130,12 @@ const frameLoop = () => {
else active = false
}

const start = controller => {
const start = (controller: Controller) => {
if (!controllers.has(controller)) {
controllers.add(controller)
if (!active) requestFrame(frameLoop)
active = true
}
}

const isActive = controller => active && controllers.has(controller)

export { start }