Skip to content

Convert Controller, Frameloop and target files to TypeScript #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 20, 2019
Merged

Convert Controller, Frameloop and target files to TypeScript #558

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
428f395
Convert target index files to TypeScript
jacobrask Feb 12, 2019
99bfda1
Remove animated.marquee
jacobrask Feb 12, 2019
767d601
Convert FrameLoop to TypeScript
jacobrask Feb 13, 2019
9a385d7
Move Controller test to live next to implementation
jacobrask Feb 13, 2019
636dfaa
Convert Controller to TypeScript
jacobrask Feb 17, 2019
c38f265
Add the SpringValue interface
jacobrask Feb 18, 2019
c651c2b
Remove unused argument from Controller constructor
jacobrask Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add the SpringValue interface
  • Loading branch information
@jacobrask
jacobrask committed Feb 19, 2019
commit c38f265eb3fff620fea5b353bdff9bb4b62ce2ef
7 changes: 7 additions & 0 deletions src/animated/Animated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
/**
* The public API for Animated classes.
*/
export interface SpringValue<T> {
getValue: () => T
}

export default abstract class Animated {
abstract addChild(child: Animated): void
abstract removeChild(child: Animated): void
Expand Down
11 changes: 4 additions & 7 deletions src/animated/createAnimatedComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,12 @@ import React, {
useRef,
} from 'react'
import { handleRef, useForceUpdate } from '../shared/helpers'
import { SpringValue } from './Animated'
import AnimatedProps from './AnimatedProps'
import { animatedApi, applyAnimatedValues } from './Globals'

type AnimatedValue<T> = {
getValue: () => T
}

type AnimateProperties<T extends object | undefined> = {
[P in keyof T]: AnimatedValue<T[P]> | T[P]
[P in keyof T]: SpringValue<T[P]> | T[P]
}

type AnimateStyleProp<P extends object> = P extends { style?: object }
Expand All @@ -32,8 +29,8 @@ type AnimateStyleProp<P extends object> = P extends { style?: object }
: P

type ScrollProps = {
scrollLeft?: AnimatedValue<number>
scrollTop?: AnimatedValue<number>
scrollLeft?: SpringValue<number>
scrollTop?: SpringValue<number>
}

type AnimatedComponentProps<C extends ReactType> = JSX.LibraryManagedAttributes<
Expand Down