Skip to content

Conversation

@ienground
Copy link
Contributor

@ienground ienground commented Apr 29, 2024

Changes: update 3D (textureWrap() ~ p5.Camera.perspective())

  • npm run lint passes
  • [Inline documentation] is included / updated

@ienground
Copy link
Contributor Author

@yinhwa @designerSejinOH
논의된 세상 -> 세계로 변경 완료했고,
2차 피드백 반영하여 수정 완료하겠습니다!

@designerSejinOH
Copy link
Contributor

@ienground 네 확인하였습니다!! 감사합니다!! 고생하셨어요!! ㅜ 승인 후 머지 요청드리겠습니다!

@designerSejinOH
Copy link
Contributor

Hi @Qianqianye @limzykenneth ! We're ready to merge this PR! Thank you ☺️ @ienground @yinhwa

@Qianqianye
Copy link
Collaborator

Thanks @ienground @designerSejinOH @yinhwa, could you resolve the conflict of this PR? Thanks!

@ienground
Copy link
Contributor Author

확인해보았는데, @Orwiss 님이 제가 맡은 부분인 p5.Camera.camera를 작업하셔서 conflicts가 발생하였네요

@davepagurek
Copy link
Collaborator

@yinhwa @ienground thanks for catching that! you're right, the z value should be documented as 800. If you use the correct value of 800 in your translations, I'll make a PR correcting the values in the English version.

@designerSejinOH
Copy link
Contributor

designerSejinOH commented May 1, 2024

@ienground 아하 넵 이해했습니다... 아마 @Orwiss 님 PR이 현재 먼저 머지되서 컨플릭이 발생했나보네요.. @ienground 님 번역으로 덮어쓰기하는 편이 좋을 것 같습니다! 제가 이 컨플릭 해결해보겠습니다!

@ienground
Copy link
Contributor Author

up벡터 y에 오타가 있어 수정하였습니다.

@designerSejinOH
Copy link
Contributor

designerSejinOH commented May 1, 2024

@Qianqianye We have resolved the conflict you mentioned! Please check and let me know if there are any issues! Thank you! @ienground @yinhwa

@Qianqianye Qianqianye merged commit 17e7ec4 into processing:main May 1, 2024
@Qianqianye
Copy link
Collaborator

Looks great, thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants