-
Notifications
You must be signed in to change notification settings - Fork 188
[p5.js KO] 3D (textureWrap() ~ p5.Camera.perspective()) #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@yinhwa @designerSejinOH |
|
@ienground 네 확인하였습니다!! 감사합니다!! 고생하셨어요!! ㅜ 승인 후 머지 요청드리겠습니다! |
|
Hi @Qianqianye @limzykenneth ! We're ready to merge this PR! Thank you |
|
Thanks @ienground @designerSejinOH @yinhwa, could you resolve the conflict of this PR? Thanks! |
|
확인해보았는데, @Orwiss 님이 제가 맡은 부분인 p5.Camera.camera를 작업하셔서 conflicts가 발생하였네요 |
|
@yinhwa @ienground thanks for catching that! you're right, the z value should be documented as 800. If you use the correct value of 800 in your translations, I'll make a PR correcting the values in the English version. |
|
@ienground 아하 넵 이해했습니다... 아마 @Orwiss 님 PR이 현재 먼저 머지되서 컨플릭이 발생했나보네요.. @ienground 님 번역으로 덮어쓰기하는 편이 좋을 것 같습니다! 제가 이 컨플릭 해결해보겠습니다! |
|
up벡터 y에 오타가 있어 수정하였습니다. |
|
@Qianqianye We have resolved the conflict you mentioned! Please check and let me know if there are any issues! Thank you! @ienground @yinhwa |
|
Looks great, thank you all! |
Changes: update 3D (textureWrap() ~ p5.Camera.perspective())
npm run lintpasses