Skip to content

Conversation

@Teemperor
Copy link
Contributor

To use C++ modules during runtime we need to generate a modulemap
and install it alongside the ROOT headers. However, right now
we need to turn on cxxmodules to generate a modulemap, which would
force experiments to fulfill all the depndencies that cxxmodules
brings with it (that is, a modern clang that can build ROOT with C++
modules).

This patch untangles the modulemap generation from the cxxmodules
option, so that we always generate a modulemap even when cxxmodules
is turned off. We now also install the modulemap alongside
the ROOT headers.

No functional change for normal ROOT expected here, as the modulemap
will just be ignored without having runtime C++ modules enabled.

To use C++ modules during runtime we need to generate a modulemap
and install it alongside the ROOT headers. However, right now
we need to turn on cxxmodules to generate a modulemap, which would
force experiments to fulfill all the depndencies that cxxmodules
brings with it (that is, a modern clang that can build ROOT with C++
modules).

This patch untangles the modulemap generation from the cxxmodules
option, so that we always generate a modulemap even when cxxmodules
is turned off. We now also install the modulemap alongside
the ROOT headers.

No functional change for normal ROOT expected here, as the modulemap
will just be ignored without having runtime C++ modules enabled.
@Teemperor
Copy link
Contributor Author

@phsft-bot build!

@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

Build failed on ubuntu14/native.
See console output.

Warnings:

Failing tests:

@phsft-bot
Copy link

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Warnings:

Failing tests:

@phsft-bot
Copy link

Build failed on slc6/gcc49.
See console output.

Warnings:

Failing tests:

@phsft-bot
Copy link

Build failed on mac1012/native.
See console output.

Warnings:

Failing tests:

@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On
How to customize builds

@Teemperor
Copy link
Contributor Author

@phsft-bot build

@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

Build failed on slc6/gcc49.
See console output.

Errors:

  • ninja: error: loading 'build.ninja': No such file or directory

Warnings:

@phsft-bot
Copy link

Build failed on ubuntu14/native.
See console output.

Warnings:

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Warnings:

Failing tests:

@vgvassilev
Copy link
Member

@phsft-bot build!

@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@vgvassilev vgvassilev self-assigned this Jun 28, 2017
@vgvassilev vgvassilev self-requested a review June 28, 2017 15:52
@phsft-bot
Copy link

Build failed on slc6/gcc49.
See console output.

Warnings:

Failing tests:

@phsft-bot
Copy link

Build failed on ubuntu14/native.
See console output.

Warnings:

Failing tests:

@phsft-bot
Copy link

@vgvassilev
Copy link
Member

@phsft-bot build just on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=Off -Dcxxmodules=On

@phsft-bot
Copy link

Starting build on clang_gcc62/slc6 with flags -Dvc=OFF -Dimt=ON -Dccache=Off -Dcxxmodules=On
How to customize builds

@phsft-bot
Copy link

Build failed on slc6/clang_gcc62.
See console output.

Errors:

  • ninja: error: loading 'build.ninja': No such file or directory

Warnings:

@vgvassilev
Copy link
Member

@Teemperor could you check the last failure?

@vgvassilev
Copy link
Member

Seems and infrastructure issue.

@vgvassilev vgvassilev merged commit 76f472a into root-project:master Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants