-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Always generate a ROOT modulemap and install it. #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To use C++ modules during runtime we need to generate a modulemap and install it alongside the ROOT headers. However, right now we need to turn on cxxmodules to generate a modulemap, which would force experiments to fulfill all the depndencies that cxxmodules brings with it (that is, a modern clang that can build ROOT with C++ modules). This patch untangles the modulemap generation from the cxxmodules option, so that we always generate a modulemap even when cxxmodules is turned off. We now also install the modulemap alongside the ROOT headers. No functional change for normal ROOT expected here, as the modulemap will just be ignored without having runtime C++ modules enabled.
|
@phsft-bot build! |
|
Starting build on |
|
Build failed on ubuntu14/native. Warnings:
Failing tests: |
|
Build failed on centos7/gcc49. Warnings:
Failing tests: |
|
Build failed on slc6/gcc62. Warnings:
Failing tests: |
|
Build failed on slc6/gcc49. Warnings:
Failing tests: |
|
Build failed on mac1012/native. Warnings:
Failing tests: |
|
Starting build on |
|
Starting build on |
|
@phsft-bot build |
|
Starting build on |
|
Build failed on slc6/gcc49. Errors:
Warnings:
|
|
Build failed on ubuntu14/native. Warnings:
|
|
Build failed on slc6/gcc62. Warnings:
Failing tests: |
|
@phsft-bot build! |
|
Starting build on |
|
Build failed on slc6/gcc49. Warnings:
Failing tests: |
|
Build failed on ubuntu14/native. Warnings:
Failing tests: |
|
Build failed on mac1012/native. Warnings:
Failing tests: |
|
@phsft-bot build just on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=Off -Dcxxmodules=On |
|
Starting build on |
|
Build failed on slc6/clang_gcc62. Errors:
Warnings:
|
|
@Teemperor could you check the last failure? |
|
Seems and infrastructure issue. |
To use C++ modules during runtime we need to generate a modulemap
and install it alongside the ROOT headers. However, right now
we need to turn on cxxmodules to generate a modulemap, which would
force experiments to fulfill all the depndencies that cxxmodules
brings with it (that is, a modern clang that can build ROOT with C++
modules).
This patch untangles the modulemap generation from the cxxmodules
option, so that we always generate a modulemap even when cxxmodules
is turned off. We now also install the modulemap alongside
the ROOT headers.
No functional change for normal ROOT expected here, as the modulemap
will just be ignored without having runtime C++ modules enabled.