-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[cxxmodules] Refactor LoadCoreModules and fix nullptr deref #1391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LoadCoreModules crashes when one of the core modules wasn't found as we call `findModule` and then dereference that result unconditionally. It also calls `findModule` and then passes the found module name again to `findModule` in the `LoadModule` function. This commit refactors this code and fixes those bugs.
|
Starting build on |
|
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on |
|
Starting build on |
|
I have a PR #1392 addressing that in a similar way. |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more Failing tests:
And 31 more |
LoadCoreModules crashes when one of the core modules wasn't
found as we call
findModuleand then dereference that resultunconditionally. It also calls
findModuleand then passesthe found module name again to
findModulein theLoadModulefunction.
This commit refactors this code and fixes those bugs.