Skip to content

Conversation

@Teemperor
Copy link
Contributor

LoadCoreModules crashes when one of the core modules wasn't
found as we call findModule and then dereference that result
unconditionally. It also calls findModule and then passes
the found module name again to findModule in the LoadModule
function.

This commit refactors this code and fixes those bugs.

LoadCoreModules crashes when one of the core modules wasn't
found as we call `findModule` and then dereference that result
unconditionally. It also calls `findModule` and then passes
the found module name again to `findModule` in the `LoadModule`
function.

This commit refactors this code and fixes those bugs.
@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@Teemperor
Copy link
Contributor Author

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

@phsft-bot
Copy link

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@vgvassilev
Copy link
Member

I have a PR #1392 addressing that in a similar way.

@Teemperor Teemperor closed this Nov 29, 2017
@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Errors:

Warnings:

  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module setDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multisetDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module valarrayDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module listDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module map2Dict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimapDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module vectorDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module dequeDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_setDict:

And 7 more

Failing tests:

And 31 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants