[Cxxmodules] Rely LazyFunctionAutoLoad for loading libraries #2559

yamaguchi1024 · 2018-08-30T14:19:07Z

"InterestingDecl"s are decls which compiler needs to know its address.
We were causing deserialization from HandleInterestingDecl to resolve
the address, but given that modules have smarter way to solve symbols
in LazyFunctionAutoLoad, we can use this instead.

This improves modules startup time by 13Mbytes.

phsft-bot · 2018-08-30T14:19:20Z

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

phsft-bot · 2018-08-30T14:42:03Z

Build failed on ubuntu16/native.
See console output.

Failing tests:

projectroot.roottest.root.meta.tclass.roottest_root_meta_tclass_execReadTmplt

yamaguchi1024 · 2018-08-30T18:03:01Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2018-08-30T18:03:10Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

Axel-Naumann · 2018-08-31T09:20:04Z

interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp

  if (m_unresolvedSymbols.empty())
    return false;

+  static std::vector<std::string> allreadyNotified;


We can have multiple instances of IncrementalExecutor per process. Please make this a member of IncrementalExecutor.

Axel-Naumann · 2018-08-31T09:20:15Z

interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp

  if (m_unresolvedSymbols.empty())
    return false;

+  static std::vector<std::string> allreadyNotified;


Spelling, "already"

Axel-Naumann · 2018-08-31T09:21:57Z

interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp

    return false;

+  static std::vector<std::string> allreadyNotified;
+  // Call LazyFunctionAutoLoad to resolve symbols from a library and return its address


diagnoseUnresolvedSymbols() is really only meant to diagnose. You probably want to use the symbol provision utility called by NotifyLazyFunctionCreators().

What's symbol provision utility? Do you mean I should move this to callees of diagnoseUnresolvedSymbols()? There are several places who is calling this function, so I'm afraid that it'll be duplicate

phsft-bot · 2018-09-03T09:37:49Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-09-05T14:38:30Z

Build failed on slc6/gcc62.
See console output.

phsft-bot · 2018-09-21T15:28:19Z

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

yamaguchi1024 · 2018-09-21T15:28:34Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2018-09-21T15:28:42Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-09-21T17:34:48Z

Build failed on slc6/gcc62.
See console output.

Errors:

979/1649 Test Make ReadClass error message more verbose #911: tutorial-vecops-vo004_SortAndSelect-py ............................................................***Failed Error regular expression found in output. Regex=[: error:] 12.40 sec
982/1649 Test [cxxmodules] Added missing PushTransactionRAII to rootcling. #912: tutorial-vecops-vo005_Combinations-py .............................................................***Failed Error regular expression found in output. Regex=[: error:] 12.25 sec

Failing tests:

And 104 more

yamaguchi1024 · 2018-09-24T13:06:07Z

@phsft-bot build

phsft-bot · 2018-09-24T13:06:21Z

Starting build on slc6/gcc48, slc6/clang_gcc62, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

yamaguchi1024 · 2018-09-24T13:07:02Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On

phsft-bot · 2018-09-24T13:07:23Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On
How to customize builds

phsft-bot · 2018-09-24T13:44:57Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

And 46 more

phsft-bot · 2018-09-24T14:57:46Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On
How to customize builds

yamaguchi1024 · 2018-09-24T14:58:20Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2018-09-24T14:58:28Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-09-24T16:54:44Z

Build failed on slc6/gcc62.
See console output.

Errors:

977/1649 Test Make ReadClass error message more verbose #911: tutorial-vecops-vo004_SortAndSelect-py ............................................................***Failed Error regular expression found in output. Regex=[: error:] 11.32 sec
978/1649 Test [cxxmodules] Added missing PushTransactionRAII to rootcling. #912: tutorial-vecops-vo005_Combinations-py .............................................................***Failed Error regular expression found in output. Regex=[: error:] 10.68 sec

Failing tests:

And 127 more

"InterestingDecl"s are decls which compiler needs to know its address. We were causing deserialization from HandleInterestingDecl to resolve the address, but given that modules have smarter way to solve symbols in LazyFunctionAutoLoad, we can use this instead. This improves modules startup time by 13Mbytes.

phsft-bot · 2018-10-23T16:03:17Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-10-23T17:14:56Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

And 133 more

vgvassilev · 2018-11-25T20:18:45Z

@yamaguchi1024 looks like we have another way to go. Closing for now, feel free to reopen if needed.

yamaguchi1024 added trying multiplatform tests labels Aug 30, 2018

yamaguchi1024 requested a review from Axel-Naumann as a code owner August 30, 2018 14:19

Axel-Naumann requested changes Aug 31, 2018

View reviewed changes

yamaguchi1024 force-pushed the handleinteresting branch from 04b22f1 to 9731952 Compare September 3, 2018 09:27

yamaguchi1024 removed do not review yet labels Sep 3, 2018

amadio assigned vgvassilev Sep 3, 2018

yamaguchi1024 force-pushed the handleinteresting branch from 9731952 to c4f14e4 Compare September 21, 2018 15:28

yamaguchi1024 force-pushed the handleinteresting branch from c4f14e4 to 7b31e47 Compare September 24, 2018 14:57

yamaguchi1024 added the do not merge label Sep 27, 2018

yamaguchi1024 force-pushed the handleinteresting branch from 7b31e47 to 6d630da Compare October 23, 2018 16:02

vgvassilev closed this Nov 25, 2018

yamaguchi1024 deleted the handleinteresting branch February 20, 2019 17:22

[Cxxmodules] Rely LazyFunctionAutoLoad for loading libraries #2559

[Cxxmodules] Rely LazyFunctionAutoLoad for loading libraries #2559

Uh oh!

Conversation

yamaguchi1024 commented Aug 30, 2018

Uh oh!

phsft-bot commented Aug 30, 2018

Uh oh!

phsft-bot commented Aug 30, 2018

Failing tests:

Uh oh!

yamaguchi1024 commented Aug 30, 2018

Uh oh!

phsft-bot commented Aug 30, 2018

Uh oh!

Axel-Naumann Aug 31, 2018

Choose a reason for hiding this comment

Uh oh!

Axel-Naumann Aug 31, 2018

Choose a reason for hiding this comment

Uh oh!

Axel-Naumann Aug 31, 2018

Choose a reason for hiding this comment

Uh oh!

yamaguchi1024 Sep 3, 2018

Choose a reason for hiding this comment

Uh oh!

phsft-bot commented Sep 3, 2018

Uh oh!

phsft-bot commented Sep 5, 2018

Uh oh!

phsft-bot commented Sep 21, 2018

Uh oh!

yamaguchi1024 commented Sep 21, 2018

Uh oh!

phsft-bot commented Sep 21, 2018

Uh oh!

phsft-bot commented Sep 21, 2018

Errors:

Failing tests:

Uh oh!

yamaguchi1024 commented Sep 24, 2018

Uh oh!

phsft-bot commented Sep 24, 2018

Uh oh!

yamaguchi1024 commented Sep 24, 2018

Uh oh!

phsft-bot commented Sep 24, 2018

Uh oh!

phsft-bot commented Sep 24, 2018

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2018

Uh oh!

yamaguchi1024 commented Sep 24, 2018

Uh oh!

phsft-bot commented Sep 24, 2018

Uh oh!

phsft-bot commented Sep 24, 2018

Errors:

Failing tests:

Uh oh!

phsft-bot commented Oct 23, 2018

Uh oh!

phsft-bot commented Oct 23, 2018

Failing tests:

Uh oh!

vgvassilev commented Nov 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants