Skip to content

Make ReadClass error message more verbose #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vgvassilev merged 1 commit into from
Sep 1, 2017
Merged

Make ReadClass error message more verbose #911

vgvassilev merged 1 commit into from
Sep 1, 2017

Conversation

@Teemperor
Copy link
Contributor

@Teemperor Teemperor commented Aug 31, 2017

No description provided.

@Teemperor Teemperor requested a review from pcanal as a code owner August 31, 2017 13:13
@phsft-bot
Copy link

phsft-bot commented Aug 31, 2017

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

pcanal
pcanal reviewed Aug 31, 2017
View reviewed changes
io/io/src/TBufferFile.cxx Outdated
clReq->GetSchemaRules()->HasRuleWithSourceClass(cl->GetName()) )
) ) {
Error("ReadClass", "got wrong class: %s", cl->GetName());
Error("ReadClass", "got wrong class %s instead of %s", cl->GetName(), clReq->GetName());
Copy link
Member

@pcanal pcanal Aug 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

Error("ReadClass", "The on-file class is \"'%s\" which is not compatible with the requested class: \"%s\"", cl->GetName(), clReq->GetName());

would be even better?

Copy link
Contributor Author

@Teemperor Teemperor Aug 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, updated it!

@Teemperor Teemperor force-pushed the MakeTBufferFileErrorMoreVerbose branch from 6d72579 to 4231dd0 Compare August 31, 2017 14:37
@phsft-bot
Copy link

phsft-bot commented Aug 31, 2017

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Aug 31, 2017

Build failed on ubuntu14/native.
See console output.

@phsft-bot
Copy link

phsft-bot commented Aug 31, 2017

Build failed on centos7/gcc49.
See console output.

@phsft-bot
Copy link

phsft-bot commented Aug 31, 2017

Build failed on mac1012/native.
See console output.

@phsft-bot
Copy link

phsft-bot commented Aug 31, 2017

Build failed on slc6/gcc62.
See console output.

@phsft-bot
Copy link

phsft-bot commented Aug 31, 2017

Build failed on slc6/gcc49.
See console output.

@vgvassilev
Copy link
Member

vgvassilev commented Sep 1, 2017

@phsft-bot build!

@phsft-bot
Copy link

phsft-bot commented Sep 1, 2017

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@vgvassilev vgvassilev merged commit c4aa801 into root-project:master Sep 1, 2017
@Teemperor Teemperor deleted the MakeTBufferFileErrorMoreVerbose branch December 19, 2017 08:39
This was referenced Sep 19, 2018
Merged
Merged
Closed
Merged
This was referenced Mar 10, 2020
Merged
Merged
@phsft-bot phsft-bot mentioned this pull request Aug 5, 2020
Closed
@phsft-bot phsft-bot mentioned this pull request Jun 29, 2023
Merged
@phsft-bot phsft-bot mentioned this pull request Dec 6, 2023
Closed
enirolf pushed a commit to enirolf/root that referenced this pull request Apr 23, 2025
@couet
A change in TArrow requires ref files update. (root-project#911)
b1e3dce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcanal pcanal pcanal left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Teemperor @phsft-bot @vgvassilev @pcanal