[cxxmodules] Re-introduce Cling modules #2628

yamaguchi1024 · 2018-09-17T11:36:19Z

This is a revert (316f553) of revert
(76a9ce7 and
88c1658).

phsft-bot · 2018-09-17T11:36:47Z

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

vgvassilev · 2018-09-17T12:07:32Z

cmake/modules/RootNewMacros.cmake


  if(CMAKE_PROJECT_NAME STREQUAL ROOT)
    set(includedirs -I${CMAKE_SOURCE_DIR}
-                    -I${CMAKE_SOURCE_DIR}/interpreter/cling/include # This is for the RuntimeUniverse


This will likely not build a module for RuntimUniverse.h and friends.

yamaguchi1024 · 2018-09-17T12:11:13Z

Modules is broken now, and we're still working on this PR because we cannot reproduce the error locally.

vgvassilev · 2018-09-18T08:06:05Z

You can harvest all relevant include files from the remote machine and copy them over to a local machine. Then you can readjust the rootcling invocation and start reducing. I believe that’s the way to go.

phsft-bot · 2018-09-18T16:54:10Z

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

yamaguchi1024 · 2018-09-18T16:54:49Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2018-09-18T16:55:22Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-09-19T15:14:41Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-09-19T16:04:12Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-09-19T17:23:14Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-09-19T18:35:47Z

Build failed on slc6/gcc62.
See console output.

Errors:

362/1649 Test Remove redundant null pointer checks #260: tutorial-dataframe-df024_Display ..................................................................***Failed Error regular expression found in output. Regex=[: error:] 16.95 sec
982/1649 Test [cxxmodules] Added missing PushTransactionRAII to rootcling. #912: tutorial-vecops-vo005_Combinations-py .............................................................***Failed Error regular expression found in output. Regex=[: error:] 11.36 sec
983/1649 Test Make ReadClass error message more verbose #911: tutorial-vecops-vo004_SortAndSelect-py ............................................................***Failed Error regular expression found in output. Regex=[: error:] 11.42 sec

Failing tests:

phsft-bot · 2018-09-19T18:36:36Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-09-19T19:13:47Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-09-19T19:37:39Z

Build failed on slc6/gcc62.
See console output.

phsft-bot · 2018-09-19T20:05:14Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-09-19T20:29:45Z

Build failed on slc6/gcc62.
See console output.

phsft-bot · 2018-09-19T20:38:51Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-09-20T15:17:12Z

Build failed on slc6/gcc62.
See console output.

Errors:

Error in <TCling::LoadModule>: Module RooFitCore not found!
input_line_4:1:2: error: unknown type name 'include'
input_line_4:1:1: error: expected unqualified-id
input_line_4:3:2: error: unknown type name 'include'
input_line_4:3:1: error: expected unqualified-id
input_line_4:5:2: error: unknown type name 'define'
input_line_4:22:7: error: expected ';' after top level declarator
input_line_4:39:2: error: unknown type name 'include'
/cvmfs/sft.cern.ch/lcg/contrib/gcc/6.2.0native/x86_64-slc6/bin/../lib/gcc/x86_64-pc-linux-gnu/6.2.0/../../../../include/c++/6.2.0/cassert:41:8: error: expected ';' after top level declarator
input_line_6:2:2: error: unknown type name 'line'

And 15 more

yamaguchi1024 · 2018-09-20T15:21:03Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2018-09-20T15:21:23Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-09-20T16:36:46Z

Build failed on slc6/gcc62.
See console output.

Errors:

987/1649 Test Make ReadClass error message more verbose #911: tutorial-vecops-vo004_SortAndSelect-py ............................................................***Failed Error regular expression found in output. Regex=[: error:] 15.85 sec
988/1649 Test [cxxmodules] Added missing PushTransactionRAII to rootcling. #912: tutorial-vecops-vo005_Combinations-py .............................................................***Failed Error regular expression found in output. Regex=[: error:] 15.49 sec

Failing tests:

And 5 more

phsft-bot · 2018-09-21T14:55:08Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-09-21T16:13:14Z

Build failed on slc6/gcc62.
See console output.

Errors:

978/1649 Test Make ReadClass error message more verbose #911: tutorial-vecops-vo004_SortAndSelect-py ............................................................***Failed Error regular expression found in output. Regex=[: error:] 10.93 sec
979/1649 Test [cxxmodules] Added missing PushTransactionRAII to rootcling. #912: tutorial-vecops-vo005_Combinations-py .............................................................***Failed Error regular expression found in output. Regex=[: error:] 10.85 sec

Failing tests:

And 6 more

vgvassilev · 2018-09-23T13:46:39Z

@phsft-bot build just on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On

phsft-bot · 2018-09-23T13:57:08Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On
How to customize builds

phsft-bot · 2018-09-23T14:44:24Z

Build failed on slc6/gcc62.
See console output.

yamaguchi1024 · 2018-09-24T07:57:03Z

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2018-09-24T08:05:28Z

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

yamaguchi1024 · 2018-09-24T08:36:51Z

@phsft-bot build

phsft-bot · 2018-09-24T08:37:12Z

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

phsft-bot · 2018-09-24T09:24:49Z

Build failed on slc6-i686/gcc49.
See console output.

Failing tests:

projectroot.roottest.python.JupyROOT.roottest_python_JupyROOT_simpleCppMagic

yamaguchi1024 · 2018-09-24T10:04:34Z

@phsft-bot build

phsft-bot · 2018-09-24T10:04:41Z

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

phsft-bot · 2018-09-24T10:58:35Z

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

This reverts commit 316f553.

phsft-bot · 2018-09-24T12:30:01Z

Build failed on windows10/vc15.
See console output.

yamaguchi1024 · 2018-09-24T12:31:01Z

@phsft-bot build

phsft-bot · 2018-09-24T12:31:09Z

Starting build on slc6/gcc48, slc6/clang_gcc62, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

phsft-bot · 2018-09-24T13:51:54Z

Build failed on slc6/clang_gcc62.
See console output.

Warnings:

/mnt/build/jenkins/workspace/root-pullrequests-build/root/net/http/civetweb/civetweb.c:2994:8: warning: implicit declaration of function 'pthread_setname_np' is invalid in C99 [-Wimplicit-function-declaration]
include/TMVA/MethodDNN.h:56:9: warning: 'DNNCPU' macro redefined [-Wmacro-redefined]

Failing tests:

yamaguchi1024 added the do not merge label Sep 17, 2018

yamaguchi1024 requested review from Axel-Naumann and amadio as code owners September 17, 2018 11:36

amadio assigned vgvassilev Sep 17, 2018

vgvassilev reviewed Sep 17, 2018

View reviewed changes

yamaguchi1024 force-pushed the revertrevert branch from f86c2eb to 0e00acd Compare September 18, 2018 16:53

yamaguchi1024 requested a review from pcanal as a code owner September 18, 2018 16:53

yamaguchi1024 force-pushed the revertrevert branch from 0e00acd to 71ee64f Compare September 19, 2018 15:14

yamaguchi1024 force-pushed the revertrevert branch from 71ee64f to 7d76894 Compare September 19, 2018 16:03

yamaguchi1024 force-pushed the revertrevert branch from 7d76894 to 8ab3ffe Compare September 19, 2018 17:23

yamaguchi1024 force-pushed the revertrevert branch from 8ab3ffe to f6add7b Compare September 19, 2018 18:36

yamaguchi1024 force-pushed the revertrevert branch from f6add7b to 264af7f Compare September 19, 2018 19:13

yamaguchi1024 force-pushed the revertrevert branch from 264af7f to a9df55d Compare September 19, 2018 20:04

yamaguchi1024 force-pushed the revertrevert branch from a9df55d to 2134b04 Compare September 19, 2018 20:38

yamaguchi1024 removed the do not merge label Sep 20, 2018

yamaguchi1024 force-pushed the revertrevert branch from 7ea2b29 to 2fabd55 Compare September 21, 2018 14:54

yamaguchi1024 force-pushed the revertrevert branch from 2fabd55 to e4978c4 Compare September 24, 2018 07:54

yamaguchi1024 changed the title ~~[cxxmodules] Fix Cling modules becoming infinite loop~~ [cxxmodules] Re-introduce Cling modules Sep 24, 2018

yamaguchi1024 force-pushed the revertrevert branch from e4978c4 to ee12b2c Compare September 24, 2018 10:58

yamaguchi1024 added 2 commits September 24, 2018 12:59

Include cmath instead of math.h in roofit

a4058d1

Revert "[cxxmodule] Fix nightlies (root-project#2577)"

ee12b2c

This reverts commit 316f553.

vgvassilev merged commit 533dd5e into root-project:master Sep 25, 2018

yamaguchi1024 deleted the revertrevert branch September 27, 2018 22:24

[cxxmodules] Re-introduce Cling modules #2628

[cxxmodules] Re-introduce Cling modules #2628

Uh oh!

Conversation

yamaguchi1024 commented Sep 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phsft-bot commented Sep 17, 2018

Uh oh!

vgvassilev Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

yamaguchi1024 commented Sep 17, 2018

Uh oh!

vgvassilev commented Sep 18, 2018

Uh oh!

phsft-bot commented Sep 18, 2018

Uh oh!

yamaguchi1024 commented Sep 18, 2018

Uh oh!

phsft-bot commented Sep 18, 2018

Uh oh!

phsft-bot commented Sep 19, 2018

Uh oh!

phsft-bot commented Sep 19, 2018

Uh oh!

phsft-bot commented Sep 19, 2018

Uh oh!

phsft-bot commented Sep 19, 2018

Errors:

Failing tests:

Uh oh!

phsft-bot commented Sep 19, 2018

Uh oh!

phsft-bot commented Sep 19, 2018

Uh oh!

phsft-bot commented Sep 19, 2018

Uh oh!

phsft-bot commented Sep 19, 2018

Uh oh!

phsft-bot commented Sep 19, 2018

Uh oh!

phsft-bot commented Sep 19, 2018

Uh oh!

phsft-bot commented Sep 20, 2018

Errors:

Uh oh!

yamaguchi1024 commented Sep 20, 2018

Uh oh!

phsft-bot commented Sep 20, 2018

Uh oh!

phsft-bot commented Sep 20, 2018

Errors:

Failing tests:

Uh oh!

phsft-bot commented Sep 21, 2018

Uh oh!

phsft-bot commented Sep 21, 2018

Errors:

Failing tests:

Uh oh!

vgvassilev commented Sep 23, 2018

Uh oh!

phsft-bot commented Sep 23, 2018

Uh oh!

phsft-bot commented Sep 23, 2018

Uh oh!

yamaguchi1024 commented Sep 24, 2018

Uh oh!

phsft-bot commented Sep 24, 2018

Uh oh!

yamaguchi1024 commented Sep 24, 2018

Uh oh!

phsft-bot commented Sep 24, 2018

Uh oh!

phsft-bot commented Sep 24, 2018

Failing tests:

Uh oh!

yamaguchi1024 commented Sep 24, 2018

Uh oh!

yamaguchi1024 commented Sep 17, 2018 •

edited

Loading