Skip to content

Conversation

@yamaguchi1024
Copy link
Contributor

@yamaguchi1024 yamaguchi1024 commented Sep 25, 2018

Previously, [system] was used to mark modules which were supporsed be implicitly built by rootcling for runtime modules. This was a workaround, and it was causing SourceLocation error in cxxmodules as it is also using the same modulemap.

To remove the workaround, we are introducing a new convention that modules start with ROOT_ is treated as "ROOT system modules", which can be build implicitly.

@phsft-bot
Copy link

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

@phsft-bot
Copy link

Build failed on centos7/gcc7.
See console output.

Warnings:

  • ../root/core/newdelete/src/NewDelete.cxx:217:11: warning: ‘operator new’ must not return NULL unless it is declared ‘throw()’ (or -fcheck-new is in effect)
  • ../root/core/newdelete/src/NewDelete.cxx:344:11: warning: ‘operator new’ must not return NULL unless it is declared ‘throw()’ (or -fcheck-new is in effect)
  • ../root/core/newdelete/src/NewDelete.cxx:263:6: warning: the program should also define ‘void operator delete(void*, std::size_t)’ [-Wsized-deallocation]
  • ../root/core/newdelete/src/NewDelete.cxx:367:6: warning: the program should also define ‘void operator delete [](void*, std::size_t)’ [-Wsized-deallocation]
  • /cvmfs/sft.cern.ch/lcg/views/LCG_rootext20180517/x86_64-centos7-gcc7-opt/include/python2.7/unicodeobject.h:534:24: warning: ISO C++1z does not allow ‘register’ storage class specifier [-Wregister]
  • /cvmfs/sft.cern.ch/lcg/views/LCG_rootext20180517/x86_64-centos7-gcc7-opt/include/python2.7/unicodeobject.h:553:24: warning: ISO C++1z does not allow ‘register’ storage class specifier [-Wregister]
  • /cvmfs/sft.cern.ch/lcg/views/LCG_rootext20180517/x86_64-centos7-gcc7-opt/include/python2.7/unicodeobject.h:575:29: warning: ISO C++1z does not allow ‘register’ storage class specifier [-Wregister]
  • /cvmfs/sft.cern.ch/lcg/views/LCG_rootext20180517/x86_64-centos7-gcc7-opt/include/python2.7/unicodeobject.h:593:23: warning: ISO C++1z does not allow ‘register’ storage class specifier [-Wregister]
  • /cvmfs/sft.cern.ch/lcg/views/LCG_rootext20180517/x86_64-centos7-gcc7-opt/include/python2.7/stringobject.h:173:24: warning: ISO C++1z does not allow ‘register’ storage class specifier [-Wregister]
  • /cvmfs/sft.cern.ch/lcg/views/LCG_rootext20180517/x86_64-centos7-gcc7-opt/include/python2.7/stringobject.h:174:21: warning: ISO C++1z does not allow ‘register’ storage class specifier [-Wregister]

And 314 more

Failing tests:

@phsft-bot
Copy link

Build failed on windows10/vc15.
See console output.

@yamaguchi1024
Copy link
Contributor Author

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

@phsft-bot
Copy link

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Errors:

  • Error: Had to build non-system module ROOT_Foundation_Stage1_NoRTTI implicitly. You first need to
  • Error: Had to build non-system module ROOT_Foundation_C implicitly. You first need to

@phsft-bot
Copy link

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@yamaguchi1024 yamaguchi1024 changed the title [cxxmodules] Mark only system headers [system] [cxxmodules] Allow ROOT_ prefix module to be implicitly build by rootcling Sep 26, 2018
@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Errors:

  • Error: Had to build non-system module _Builtin_intrinsics implicitly. You first need to

@phsft-bot
Copy link

Starting build on slc6/gcc62 with flags -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

…cling

Previously, [system] was used to mark modules which were supporsed be
implicitly built by rootcling for runtime modules. This was a workaround, and it was causing
SourceLocation error in cxxmodules as it is also using the same
modulemap.

To remove the workaround, we are introducing a new convention that modules
start with ROOT_ is treated as "ROOT system modules", which can be build
implicitly.
@phsft-bot
Copy link

@vgvassilev vgvassilev merged commit 0934170 into root-project:master Sep 26, 2018
@yamaguchi1024 yamaguchi1024 deleted the modulemap branch September 27, 2018 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants