-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[cxxmodules] Allow ROOT_ prefix module to be implicitly build by rootcling #2684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Starting build on |
|
Build failed on centos7/gcc7. Warnings:
And 314 more Failing tests: |
|
Build failed on windows10/vc15. |
|
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on |
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
|
38b0c20 to
31e0985
Compare
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
|
31e0985 to
a92cacb
Compare
|
Starting build on |
…cling Previously, [system] was used to mark modules which were supporsed be implicitly built by rootcling for runtime modules. This was a workaround, and it was causing SourceLocation error in cxxmodules as it is also using the same modulemap. To remove the workaround, we are introducing a new convention that modules start with ROOT_ is treated as "ROOT system modules", which can be build implicitly.
Previously, [system] was used to mark modules which were supporsed be implicitly built by rootcling for runtime modules. This was a workaround, and it was causing SourceLocation error in cxxmodules as it is also using the same modulemap.
To remove the workaround, we are introducing a new convention that modules start with ROOT_ is treated as "ROOT system modules", which can be build implicitly.