Fix for ROOT-8452 #516
Fix for ROOT-8452 #516
Conversation
Adds also full support for wildcards, at least for the backends supporting it,
and for generic paths on the command line, e.g. for
$ root root://host.my.dom//my/dir/file.root?option#anchor
Adds also full support for wildcards, at least for the backends supporting it,
and for generic paths on the command line, e.g. for
$ root root://host.my.dom//my/dir/file.root?option#anchor
(with clang-format approval).
|
looks good. Can you fix the minor formatting issues? |
|
@phsft-bot build |
|
Starting build on |
|
Starting build on |
|
Apparently many tests are broken by the change in the command line processing. |
* Fix for ROOT-8732 - PyROOT cannot read/write C++ class fields of Double32_t * Try to please clang-format * Again :-(
Currently, we run only a very small subset of checks (the static analysis checks). For PRs clang-tidy reports only if the regression is triggered by one of the modified lines. There is a cron-job mode which is unused and it could be enabled (through travis) in future. If enabled now, it reports multitude of issues (reports stop at 10K lines of log due to travis limit).
In the input file of the aforementioned tutorial, some top-level branches depended on another branch that determined their size for every entry (e.g. the size of an array branch). When processing this kind of data, branches that depend on size (or count) branches will trigger a call to TBranch::GetEntry on the latter to ensure their size is read. The scenario described above made the parallelization of TTree::GetEntry thread-unsafe, since a count branch could be processed at the same time by two tasks: its own task and the task that was processing the branch that needed the size. This has been solved by factoring out the count branches, which are processed first sequentially and independently of the rest of the branches. The latter can be processed safely in parallel afterwards because all the sizes have been read already.
In some circumstances it might be NULL there.
|
@phsft-bot build |
|
Starting build on |
|
I close this request and provide a new one with conflicts resolved and additional fixes. |
|
Starting build on |
|
Starting build on |
3 similar comments
|
Starting build on |
|
Starting build on |
|
Starting build on |
|
Starting build on |
9 participants
Rewrite of TChain::ParseTreeFilename and mods in TApplication::GetOptions.
Adds also full support for wildcards, at least for the backends supporting it,
and for generic paths on the command line, e.g. for