Fix Issue #6443: spurrious auto-parsing due to @ class, pair, __pair_base and enums #6445

pcanal · 2020-09-24T17:42:04Z

Avoid auto-parsing when core/meta does:

* Search for a enum type
* Search for __base_pair
* Search for one of ROOT synthetic class (for I/O customization rules)

where a class is expected.

phsft-bot · 2020-09-24T17:42:13Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-09-24T17:55:45Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2020-09-24T17:46:07.751Z] /home/sftnight/build/workspace/root-pullrequests-build/root/io/io/src/TGenCollectionProxy.cxx:391:21: warning: unused variable ‘enumTable’ [-Wunused-variable]

Failing tests:

And 24 more

phsft-bot · 2020-09-24T18:15:44Z

Build failed on ROOT-performance-centos7-multicore/default.
Running on olhswep22.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Warnings:

[2020-09-24T18:00:57.810Z] /data/sftnight/workspace/root-pullrequests-build/root/io/io/src/TGenCollectionProxy.cxx:391:21: warning: unused variable ‘enumTable’ [-Wunused-variable]

Failing tests:

And 34 more

phsft-bot · 2020-09-24T18:20:36Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2020-09-24T17:53:10.727Z] /home/sftnight/build/workspace/root-pullrequests-build/root/io/io/src/TGenCollectionProxy.cxx:391:21: warning: unused variable ‘enumTable’ [-Wunused-variable]

Failing tests:

And 20 more

phsft-bot · 2020-09-24T18:21:12Z

Build failed on mac1015/cxx17.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Warnings:

[2020-09-24T18:01:20.229Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/io/io/src/TGenCollectionProxy.cxx:391:21: warning: unused variable 'enumTable' [-Wunused-variable]

Failing tests:

And 20 more

phsft-bot · 2020-09-24T18:30:36Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2020-09-24T17:54:45.968Z] /home/sftnight/build/workspace/root-pullrequests-build/root/io/io/src/TGenCollectionProxy.cxx:391:21: warning: unused variable ‘enumTable’ [-Wunused-variable]

Failing tests:

And 16 more

phsft-bot · 2020-09-24T18:41:37Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2020-09-24T18:02:26.075Z] /mnt/build/workspace/root-pullrequests-build/root/io/io/src/TGenCollectionProxy.cxx:391:21: warning: unused variable ‘enumTable’ [-Wunused-variable]

Failing tests:

And 23 more

phsft-bot · 2020-09-24T18:42:34Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-09-24T20:11:54Z

Build failed on mac1014/python3.
Running on macitois19.cern.ch:/ec/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2020-09-24T19:08:34.333Z] /ec/build/workspace/root-pullrequests-build/root/io/io/src/TGenCollectionProxy.cxx:391:21: warning: unused variable 'enumTable' [-Wunused-variable]

Failing tests:

And 23 more

phsft-bot · 2020-09-24T21:53:29Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-09-24T22:07:17Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2020-09-24T21:56:21.870Z] /build/workspace/root-pullrequests-build/root/io/io/src/TGenCollectionProxy.cxx:391:21: warning: unused variable ‘enumTable’ [-Wunused-variable]

Failing tests:

And 24 more

phsft-bot · 2020-09-24T22:13:46Z

Build failed on ROOT-performance-centos7-multicore/default.
Running on olhswep22.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Warnings:

[2020-09-24T21:58:50.614Z] /data/sftnight/workspace/root-pullrequests-build/root/io/io/src/TGenCollectionProxy.cxx:391:21: warning: unused variable ‘enumTable’ [-Wunused-variable]

Failing tests:

And 33 more

phsft-bot · 2020-09-24T22:15:58Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2020-09-24T21:56:34.882Z] /build/workspace/root-pullrequests-build/root/io/io/src/TGenCollectionProxy.cxx:391:21: warning: unused variable ‘enumTable’ [-Wunused-variable]

Failing tests:

And 20 more

phsft-bot · 2020-09-24T22:18:26Z

Build failed on mac1015/cxx17.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Warnings:

[2020-09-24T21:58:41.575Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/io/io/src/TGenCollectionProxy.cxx:391:21: warning: unused variable 'enumTable' [-Wunused-variable]

Failing tests:

And 20 more

phsft-bot · 2020-09-24T22:22:02Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2020-09-24T21:57:12.867Z] /mnt/build/workspace/root-pullrequests-build/root/io/io/src/TGenCollectionProxy.cxx:391:21: warning: unused variable ‘enumTable’ [-Wunused-variable]

Failing tests:

And 23 more

phsft-bot · 2020-09-24T22:31:07Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2020-09-24T22:07:19.237Z] /home/sftnight/build/workspace/root-pullrequests-build/root/io/io/src/TGenCollectionProxy.cxx:391:21: warning: unused variable ‘enumTable’ [-Wunused-variable]

Failing tests:

And 16 more

phsft-bot · 2020-09-24T22:55:29Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-09-24T23:44:13Z

Build failed on mac1014/python3.
Running on macitois19.cern.ch:/ec/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2020-09-24T22:41:29.523Z] /ec/build/workspace/root-pullrequests-build/root/io/io/src/TGenCollectionProxy.cxx:391:21: warning: unused variable 'enumTable' [-Wunused-variable]

Failing tests:

And 23 more

phsft-bot · 2020-09-24T23:56:35Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-09-25T00:41:48Z

Build failed on ROOT-performance-centos7-multicore/default.
Running on olhswep22.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.tree.addresses.roottest_root_tree_addresses_make

pcanal · 2020-09-25T01:23:57Z

@phsft-bot build just on ROOT-performance-centos7-multicore/default.

phsft-bot · 2020-09-25T01:24:05Z

Didn't recognize ROOT-performance-centos7-multicore/default. aborting build.

pcanal · 2020-09-25T01:30:36Z

@phsft-bot build just on ROOT-performance-centos7-multicore/default

phsft-bot · 2020-09-25T01:30:43Z

Starting build on ROOT-performance-centos7-multicore/default
How to customize builds

phsft-bot · 2020-09-25T01:51:31Z

Build failed on ROOT-performance-centos7-multicore/default.
Running on olhswep22.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.tree.addresses.roottest_root_tree_addresses_make

phsft-bot · 2020-09-25T02:05:52Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-09-30T20:03:58Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

In particular use TEnum::GetEnum 'do-not-autoparse-nor-autoload' feature.

artificial/synthetic classes are created in the support of I/O customization rules.

just in case we need to make it more complexe and/or replace it at a later date

… instances

…oForPair

i.e. map can be split even if we don't have the interpreter info loaded for the pair and we do not even need a dictionary; we nowadays generate the TClass for most of the std::pairs

Except in the case where we know the type did exist at some point and thus is an enum (because it was not then we would have information about in the form of TStreamerInfo). The exception to the exception is the case of a custom Streamer that does not use TStreamerInfo underneath. In that case, we don't know about the class then we don't have access to the custom Streamer and thus can't read the object.

phsft-bot · 2020-09-30T20:14:05Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-09-30T20:21:39Z

Build failed on ROOT-performance-centos7-multicore/default.
Running on olhswep22.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-09-30T20:22:14Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.multicore.roottest_root_multicore_processExecutorH1Test

phsft-bot · 2020-09-30T20:30:21Z

Build failed on mac1015/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-09-30T20:33:21Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-09-30T21:19:32Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

pcanal · 2020-10-01T01:45:25Z

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

phsft-bot · 2020-10-01T01:45:32Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14 with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2020-10-01T02:52:24Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

pcanal linked an issue Sep 24, 2020 that may be closed by this pull request

Spurrious auto-parsing (as seen with CMS file and libraries) #6443

Closed

pcanal changed the title ~~Fix Issue #6443~~ Fix Issue #6443: spurrious auto-parsing due to @ class, pair, __pair_base and enums Sep 24, 2020

pcanal force-pushed the Issue-6443 branch from 99fa583 to b81f6fd Compare September 24, 2020 21:53

pcanal force-pushed the Issue-6443 branch from b81f6fd to 48f8f34 Compare September 24, 2020 23:56

pcanal added 16 commits September 30, 2020 15:12

fix off by one error in pair auto-parsing skipping

8d2567b

Also avoid auto-parsing for __pair_base during I/O init

9ca6572

Avoid auto-parsing if we can tell early that the name is an enumerator.

72c723b

In particular use TEnum::GetEnum 'do-not-autoparse-nor-autoload' feature.

Avoid spurrious auto-loading/parsing due to artificial classes.

cd04b64

artificial/synthetic classes are created in the support of I/O customization rules.

[NFC] white space

2787835

Introduce TClassEdit::IsArtificial to wrap the '@' search.

c7930cf

just in case we need to make it more complexe and/or replace it at a later date

Do not (inadvertently) stip the @@ suffix for emulated class template…

fe77942

… instances

Add TClassEdit::IsStdPair to factor out all the comparison

d51fa31

Use TClassEdit::IsStdPair

19f417d

In CheckClassInfo suspend autoparsing for std::pair

94b5a72

Migrate R__GenerateTClassForPair to TVirtualStreamerInfo::GenerateInf…

e311a8a

…oForPair

TClass::GetClass uses GenerateInfoForPair rather than auto-parsing

84cb8a5

Remove restriction (from circa 2005) that is no longer true.

2c274dc

i.e. map can be split even if we don't have the interpreter info loaded for the pair and we do not even need a dictionary; we nowadays generate the TClass for most of the std::pairs

[NFC] extend documentation for some of std::pair handling code

2fb16c9

TCling::CheckClassInfo switch suspensions to use RAII object.

3936c2f

Avoid auto-parsing upon seeing __pair_base

0005d17

pcanal force-pushed the Issue-6443 branch from edb0ceb to 0005d17 Compare September 30, 2020 21:19

pcanal merged commit 889defb into root-project:master Oct 14, 2020

pcanal deleted the Issue-6443 branch November 16, 2020 22:11

Fix Issue #6443: spurrious auto-parsing due to @ class, pair, __pair_base and enums #6445

Fix Issue #6443: spurrious auto-parsing due to @ class, pair, __pair_base and enums #6445

Uh oh!

Conversation

pcanal commented Sep 24, 2020

Uh oh!

phsft-bot commented Sep 24, 2020

Uh oh!

phsft-bot commented Sep 24, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Uh oh!

phsft-bot commented Sep 24, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Sep 24, 2020

Uh oh!

phsft-bot commented Sep 25, 2020

Failing tests:

Uh oh!

pcanal commented Sep 25, 2020

Uh oh!

phsft-bot commented Sep 25, 2020