Skip to content

Fix Issue #6443: spurrious auto-parsing due to @ class, pair, __pair_base and enums #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcanal merged 17 commits into from
Oct 14, 2020
Merged

Fix Issue #6443: spurrious auto-parsing due to @ class, pair, __pair_base and enums #6445

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8d2567b
fix off by one error in pair auto-parsing skipping
pcanal Sep 23, 2020
9ca6572
Also avoid auto-parsing for __pair_base during I/O init
pcanal Sep 23, 2020
72c723b
Avoid auto-parsing if we can tell early that the name is an enumerator.
pcanal Sep 24, 2020
cd04b64
Avoid spurrious auto-loading/parsing due to artificial classes.
pcanal Sep 24, 2020
2787835
[NFC] white space
pcanal Sep 24, 2020
c7930cf
Introduce TClassEdit::IsArtificial to wrap the '@' search.
pcanal Sep 24, 2020
fe77942
Do not (inadvertently) stip the @@ suffix for emulated class template…
pcanal Sep 25, 2020
d51fa31
Add TClassEdit::IsStdPair to factor out all the comparison
pcanal Sep 26, 2020
19f417d
Use TClassEdit::IsStdPair
pcanal Sep 26, 2020
94b5a72
In CheckClassInfo suspend autoparsing for std::pair
pcanal Sep 26, 2020
e311a8a
Migrate R__GenerateTClassForPair to TVirtualStreamerInfo::GenerateInf…
pcanal Sep 25, 2020
84cb8a5
TClass::GetClass uses GenerateInfoForPair rather than auto-parsing
pcanal Sep 25, 2020
2c274dc
Remove restriction (from circa 2005) that is no longer true.
pcanal Sep 26, 2020
9b1058a
Do not generate TClass for pair of unknown type(s).
pcanal Sep 28, 2020
2fb16c9
[NFC] extend documentation for some of std::pair handling code
pcanal Sep 28, 2020
3936c2f
TCling::CheckClassInfo switch suspensions to use RAII object.
pcanal Sep 29, 2020
0005d17
Avoid auto-parsing upon seeing __pair_base
pcanal Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix off by one error in pair auto-parsing skipping
  • Loading branch information
@pcanal
pcanal committed Sep 30, 2020
commit 8d2567b742a015652da4e837242d14f47a9859a6
2 changes: 1 addition & 1 deletion core/foundation/src/TClassEdit.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,7 @@ void TClassEdit::GetNormalizedName(std::string &norm_name, std::string_view name
TClassEdit::TSplitType splitname(norm_name.c_str(),(TClassEdit::EModType)(TClassEdit::kLong64 | TClassEdit::kDropStd | TClassEdit::kDropStlDefault | TClassEdit::kKeepOuterConst));
splitname.ShortType(norm_name, TClassEdit::kDropStd | TClassEdit::kDropStlDefault | TClassEdit::kResolveTypedef | TClassEdit::kKeepOuterConst);

if (splitname.fElements.size() == 3 && (splitname.fElements[0] == "std::pair" || splitname.fElements[0] == "pair")) {
Copy link
Member

@Axel-Naumann Axel-Naumann Sep 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not a bit fan of == 3 and == 4 without any comment. See also the change in tree/treeplayer/src/TTreeGeneratorBase.cxx

Copy link
Member Author

@pcanal pcanal Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In TTreeGeneratorBase.cxx, I left 3 or 4 because the likely wrong one was there with no (obvious negative consequence) and (I should add a comment) thus it might actually be the right one .... i.e. to remove it I would have to try to produce a test and the code is used little enough to not be a priority (to spend the time to write the test).

Copy link
Member

@Axel-Naumann Axel-Naumann Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment would be great! :-)

Copy link
Member Author

@pcanal pcanal Sep 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without any comment.

Well that's part of the documented contract of TClassEdit::TSplitType :)

But nevertheless I will add a comment.

if (splitname.fElements.size() == 4 && (splitname.fElements[0] == "std::pair" || splitname.fElements[0] == "pair")) {
// We don't want to lookup the std::pair itself.
std::string first, second;
GetNormalizedName(first, splitname.fElements[1]);
Expand Down