Skip to content

Fix Issue #6443: spurrious auto-parsing due to @ class, pair, __pair_base and enums #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcanal merged 17 commits into from
Oct 14, 2020
Merged

Fix Issue #6443: spurrious auto-parsing due to @ class, pair, __pair_base and enums #6445

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8d2567b
fix off by one error in pair auto-parsing skipping
pcanal Sep 23, 2020
9ca6572
Also avoid auto-parsing for __pair_base during I/O init
pcanal Sep 23, 2020
72c723b
Avoid auto-parsing if we can tell early that the name is an enumerator.
pcanal Sep 24, 2020
cd04b64
Avoid spurrious auto-loading/parsing due to artificial classes.
pcanal Sep 24, 2020
2787835
[NFC] white space
pcanal Sep 24, 2020
c7930cf
Introduce TClassEdit::IsArtificial to wrap the '@' search.
pcanal Sep 24, 2020
fe77942
Do not (inadvertently) stip the @@ suffix for emulated class template…
pcanal Sep 25, 2020
d51fa31
Add TClassEdit::IsStdPair to factor out all the comparison
pcanal Sep 26, 2020
19f417d
Use TClassEdit::IsStdPair
pcanal Sep 26, 2020
94b5a72
In CheckClassInfo suspend autoparsing for std::pair
pcanal Sep 26, 2020
e311a8a
Migrate R__GenerateTClassForPair to TVirtualStreamerInfo::GenerateInf…
pcanal Sep 25, 2020
84cb8a5
TClass::GetClass uses GenerateInfoForPair rather than auto-parsing
pcanal Sep 25, 2020
2c274dc
Remove restriction (from circa 2005) that is no longer true.
pcanal Sep 26, 2020
9b1058a
Do not generate TClass for pair of unknown type(s).
pcanal Sep 28, 2020
2fb16c9
[NFC] extend documentation for some of std::pair handling code
pcanal Sep 28, 2020
3936c2f
TCling::CheckClassInfo switch suspensions to use RAII object.
pcanal Sep 29, 2020
0005d17
Avoid auto-parsing upon seeing __pair_base
pcanal Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[NFC] extend documentation for some of std::pair handling code
  • Loading branch information
@pcanal
pcanal committed Sep 30, 2020
commit 2fb16c95c152883ba174266547d132372efc76e1
1 change: 1 addition & 0 deletions core/foundation/src/TClassEdit.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,7 @@ void TClassEdit::GetNormalizedName(std::string &norm_name, std::string_view name
TClassEdit::TSplitType splitname(norm_name.c_str(),(TClassEdit::EModType)(TClassEdit::kLong64 | TClassEdit::kDropStd | TClassEdit::kDropStlDefault | TClassEdit::kKeepOuterConst));
splitname.ShortType(norm_name, TClassEdit::kDropStd | TClassEdit::kDropStlDefault | TClassEdit::kResolveTypedef | TClassEdit::kKeepOuterConst);

// 4 elements expected: "pair", "first type name", "second type name", "trailing stars"
if (splitname.fElements.size() == 4 && (splitname.fElements[0] == "std::pair" || splitname.fElements[0] == "pair" || splitname.fElements[0] == "__pair_base")) {
Copy link
Member

@Axel-Naumann Axel-Naumann Sep 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you not use IsStdPair here?

Copy link
Member Author

@pcanal pcanal Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. The test is also on the base class name (__pair_base) and technically the name can have wild spelling. I.e. the input name (unsplit and unnormalized of course) could be "std :: pair <" and the split name lacks the < that IsStdPair expects.

Copy link
Member Author

@pcanal pcanal Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here I mean that I need to do the test after the call to Split to remove the problem with spelling (and then the name does not have the "<" and thus IsStdPair is not applicable.

Copy link
Member

@Axel-Naumann Axel-Naumann Sep 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can splitname be std::pair when splitname is the result of kDropStd? Or am I misremembering input/output of ShortType?

Copy link
Member Author

@pcanal pcanal Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually ... that's right .. the test for std::pair is here superfluous ...

// We don't want to lookup the std::pair itself.
std::string first, second;
Expand Down
5 changes: 5 additions & 0 deletions core/meta/src/TClass.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3041,8 +3041,13 @@ TClass *TClass::GetClass(const char *name, Bool_t load, Bool_t silent)
// ::Fatal("TClass::GetClass","The existing name (%s) for %s is different from the normalized name: %s\n",
// altcl->GetName(), name, normalizedName.c_str());
// }

// We want to avoid auto-parsing due to intentionally missing dictionary for std::pair.
// However, we don't need this special treatement in rootcling (there is no auto-parsing)
// and we want to make that the TClass for the pair goes through the regular creation
// mechanism (i.e. in rootcling they should be in kInterpreted state and never in
// kEmulated state) so that they have proper interpreter (ClassInfo) information which
// will be used to create the TProtoClass (if one is requested for the pair).
const bool ispair = TClassEdit::IsStdPair(normalizedName) && !IsFromRootCling();

TClass *loadedcl = 0;
Expand Down
3 changes: 3 additions & 0 deletions tree/treeplayer/src/TTreeGeneratorBase.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ namespace Internal {
directive = Form("#include \"%s\"\n",filename);
} else if (TClassEdit::IsStdPair(cl->GetName())) {
TClassEdit::TSplitType split(cl->GetName());
// 4 elements expected: "pair", "first type name", "second type name", "trailing stars"
// However legacy code had a test for 3, we will leave it here until
// a test is developed (or found :) ) that exercise these lines of code.
if (split.fElements.size() == 3 || split.fElements.size() == 4) {
for (int arg = 1; arg < 3; ++arg) {
TClass* clArg = TClass::GetClass(split.fElements[arg].c_str());
Expand Down