Allow printing a fully-qualified path in def_path_str
#147444
Merged
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
nnethercote
reviewed
Oct 7, 2025
| /// Adds the crate name prefix to paths where appropriate. | ||
| /// Unlike `with_crate_prefix`, this unconditionally uses `tcx.crate_name` instead of sometimes | ||
| /// using `crate::` for local items. | ||
| fn with_resolve_crate_name(CrateNamePrefixGuard, SHOULD_PREFIX_WITH_CRATE_NAME); |
There was a problem hiding this comment.
The interaction between SHOULD_PREFIX_WITH_CRATE and SHOULD_PREFIX_WITH_CRATE_NAME is unclear. This extends an existing problem with these flags, which is how they all interact is confusing. E.g. with_no_trimmed_paths vs with_forced_trimmed_paths. Perhaps some of them need to be tri-state enums instead of booleans?
There was a problem hiding this comment.
tri-state enums seem reasonable, but the API doesn't expose anything like that currently. we'd need to switch away from with!( ... ) macros to something like with!(CratePrinting::Expanded, ...).
There was a problem hiding this comment.
Yeah, it would be a follow-up for sure.
|
r=me if you (a) clarify how |
Previously, the local crate would always be printed as a leading `crate::`.
Allow resolving it to the crate name instead.
This allows printing a fully qualified path with:
```rust
let qualified_name = with_no_visible_paths!(with_resolve_crate_name!(
with_no_trimmed_paths!(tcx.def_path_str(def_id))
));
```
I found this useful for an out-of-tree rustc-driver. I do not currently
have a usecase in mind upstream; I'm ok if you don't want this PR for
that reason.
This does not currently have tests. I am not aware of an easy way to
test def-id printing, since it requires having access to a TyCtxt.
jyn514
force-pushed
the
fully-qualified-paths
branch
from
2e12508 to
fa9162d
Compare
|
👋 I see you commented but did not approve, so I just wanted to give a heads-up this is ready for re-review ^^ |
|
Sorry, the r=me was an implicit delegation. @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 10, 2025
Allow printing a fully-qualified path in `def_path_str`
Previously, the local crate would always be printed as a leading `crate::`. Allow resolving it to the crate name instead.
This allows printing a fully qualified path with:
```rust
let qualified_name = with_no_visible_paths!(with_resolve_crate_name!(
with_no_trimmed_paths!(tcx.def_path_str(def_id))
));
```
I found this useful for an out-of-tree rustc-driver. I do not currently have a usecase in mind upstream; I'm ok if you don't want this PR for that reason. See [#t-compiler/help > print a fully qualified path name? @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/print.20a.20fully.20qualified.20path.20name.3F/near/541560961) for additional context.
This does not currently have tests. I am not aware of an easy way to test def-id printing, since it requires having access to a TyCtxt.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
gotcha — just FYI I no longer have bors merge rights. |
|
@rustbot author |
rustbot
added
S-waiting-on-author
rustbot
added
S-waiting-on-review
|
Yeah this should be retried |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 15, 2025
Rollup of 11 pull requests Successful merges: - #143191 (Stabilize `rwlock_downgrade` library feature) - #147444 (Allow printing a fully-qualified path in `def_path_str`) - #147527 (Update t-compiler beta nomination Zulip msg) - #147670 (some `ErrorGuaranteed` cleanups) - #147676 (Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes) - #147708 (const `mem::drop`) - #147710 (Fix ICE when using contracts on async functions) - #147716 (Fix some comments) - #147718 (miri: use allocator_shim_contents codegen helper) - #147729 (ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius) - #147742 (Revert unintentional whitespace changes to rustfmt-excluded file) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 16, 2025
Rollup merge of #147444 - jyn514:fully-qualified-paths, r=nnethercote Allow printing a fully-qualified path in `def_path_str` Previously, the local crate would always be printed as a leading `crate::`. Allow resolving it to the crate name instead. This allows printing a fully qualified path with: ```rust let qualified_name = with_no_visible_paths!(with_resolve_crate_name!( with_no_trimmed_paths!(tcx.def_path_str(def_id)) )); ``` I found this useful for an out-of-tree rustc-driver. I do not currently have a usecase in mind upstream; I'm ok if you don't want this PR for that reason. See [#t-compiler/help > print a fully qualified path name? @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/print.20a.20fully.20qualified.20path.20name.3F/near/541560961) for additional context. This does not currently have tests. I am not aware of an easy way to test def-id printing, since it requires having access to a TyCtxt.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Oct 16, 2025
Rollup of 11 pull requests Successful merges: - rust-lang/rust#143191 (Stabilize `rwlock_downgrade` library feature) - rust-lang/rust#147444 (Allow printing a fully-qualified path in `def_path_str`) - rust-lang/rust#147527 (Update t-compiler beta nomination Zulip msg) - rust-lang/rust#147670 (some `ErrorGuaranteed` cleanups) - rust-lang/rust#147676 (Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes) - rust-lang/rust#147708 (const `mem::drop`) - rust-lang/rust#147710 (Fix ICE when using contracts on async functions) - rust-lang/rust#147716 (Fix some comments) - rust-lang/rust#147718 (miri: use allocator_shim_contents codegen helper) - rust-lang/rust#147729 (ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius) - rust-lang/rust#147742 (Revert unintentional whitespace changes to rustfmt-excluded file) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the local crate would always be printed as a leading
crate::. Allow resolving it to the crate name instead.This allows printing a fully qualified path with:
I found this useful for an out-of-tree rustc-driver. I do not currently have a usecase in mind upstream; I'm ok if you don't want this PR for that reason. See #t-compiler/help > print a fully qualified path name? @ 💬 for additional context.
This does not currently have tests. I am not aware of an easy way to test def-id printing, since it requires having access to a TyCtxt.