Skip to content

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Oct 14, 2025

If we've got an ErrorGuaranteed, use it.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 14, 2025

r? @spastorino

rustbot has assigned @spastorino.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@BoxyUwU
Copy link
Member

BoxyUwU commented Oct 15, 2025

@bors r+ rollup

@BoxyUwU
Copy link
Member

BoxyUwU commented Oct 15, 2025

r? BoxyUwU

@bors
Copy link
Collaborator

bors commented Oct 15, 2025

📌 Commit 4dfbf11 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2025
@rustbot rustbot assigned BoxyUwU and unassigned spastorino Oct 15, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 15, 2025
some `ErrorGuaranteed` cleanups

If we've got an `ErrorGuaranteed`, use it.
bors added a commit that referenced this pull request Oct 15, 2025
Rollup of 5 pull requests

Successful merges:

 - #143191 (Stabilize `rwlock_downgrade` library feature)
 - #147000 (std: Add Motor OS std library port)
 - #147670 (some `ErrorGuaranteed` cleanups)
 - #147716 (Fix some comments)
 - #147718 (miri: use allocator_shim_contents codegen helper)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Oct 15, 2025
Rollup of 5 pull requests

Successful merges:

 - #143191 (Stabilize `rwlock_downgrade` library feature)
 - #147000 (std: Add Motor OS std library port)
 - #147670 (some `ErrorGuaranteed` cleanups)
 - #147716 (Fix some comments)
 - #147718 (miri: use allocator_shim_contents codegen helper)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Oct 15, 2025
Rollup of 11 pull requests

Successful merges:

 - #143191 (Stabilize `rwlock_downgrade` library feature)
 - #147444 (Allow printing a fully-qualified path in `def_path_str`)
 - #147527 (Update t-compiler beta nomination Zulip msg)
 - #147670 (some `ErrorGuaranteed` cleanups)
 - #147676 (Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes)
 - #147708 (const `mem::drop`)
 - #147710 (Fix ICE when using contracts on async functions)
 - #147716 (Fix some comments)
 - #147718 (miri: use allocator_shim_contents codegen helper)
 - #147729 (ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius)
 - #147742 (Revert unintentional whitespace changes to rustfmt-excluded file)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e7c1e19 into rust-lang:master Oct 16, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 16, 2025
rust-timer added a commit that referenced this pull request Oct 16, 2025
Rollup merge of #147670 - lcnr:no-ok-ret-guar, r=BoxyUwU

some `ErrorGuaranteed` cleanups

If we've got an `ErrorGuaranteed`, use it.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Oct 16, 2025
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#143191 (Stabilize `rwlock_downgrade` library feature)
 - rust-lang/rust#147444 (Allow printing a fully-qualified path in `def_path_str`)
 - rust-lang/rust#147527 (Update t-compiler beta nomination Zulip msg)
 - rust-lang/rust#147670 (some `ErrorGuaranteed` cleanups)
 - rust-lang/rust#147676 (Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes)
 - rust-lang/rust#147708 (const `mem::drop`)
 - rust-lang/rust#147710 (Fix ICE when using contracts on async functions)
 - rust-lang/rust#147716 (Fix some comments)
 - rust-lang/rust#147718 (miri: use allocator_shim_contents codegen helper)
 - rust-lang/rust#147729 (ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius)
 - rust-lang/rust#147742 (Revert unintentional whitespace changes to rustfmt-excluded file)

r? `@ghost`
`@rustbot` modify labels: rollup
@lcnr lcnr deleted the no-ok-ret-guar branch October 16, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants