ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius #147729
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polonius liveness has to contain boring locals, and we ignore them in diagnostics to match NLL diagnostics, since they doesn't contain boring locals. We ignored these when explaining why a loan contained a point due to a use of a live var, but not when it contained a point due to a drop of a live var.
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
no 🎉 s just yet, there are still 2 annoying failures due to opaque types weirdness in liveness :) these were just the last differences in diagnostics content, compared to, say, unsoundness |
😦☹ |
bors
added a commit
that referenced
this pull request
Oct 15, 2025
Rollup of 11 pull requests Successful merges: - #143191 (Stabilize `rwlock_downgrade` library feature) - #147444 (Allow printing a fully-qualified path in `def_path_str`) - #147527 (Update t-compiler beta nomination Zulip msg) - #147670 (some `ErrorGuaranteed` cleanups) - #147676 (Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes) - #147708 (const `mem::drop`) - #147710 (Fix ICE when using contracts on async functions) - #147716 (Fix some comments) - #147718 (miri: use allocator_shim_contents codegen helper) - #147729 (ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius) - #147742 (Revert unintentional whitespace changes to rustfmt-excluded file) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 16, 2025
Rollup merge of #147729 - lqd:polonius-diagnostics, r=jackh726 ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius Polonius liveness has to contain boring locals, and we ignore them in diagnostics, to match NLL diagnostics that never involve any boring locals. When explaining why a borrow contains a point, I ignored these boring locals when it was due to a use of a live var, but forgot to do so when the cause was because of a drop of a live var. This is what was causing the last two (known) diagnostics differences under the polonius compare-mode: - `tests/ui/dropck/dropck_trait_cycle_checked.rs` - `tests/ui/unboxed-closures/unboxed-closures-failed-recursive-fn-1.rs` r? `@jackh726`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Oct 16, 2025
Rollup of 11 pull requests Successful merges: - rust-lang/rust#143191 (Stabilize `rwlock_downgrade` library feature) - rust-lang/rust#147444 (Allow printing a fully-qualified path in `def_path_str`) - rust-lang/rust#147527 (Update t-compiler beta nomination Zulip msg) - rust-lang/rust#147670 (some `ErrorGuaranteed` cleanups) - rust-lang/rust#147676 (Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes) - rust-lang/rust#147708 (const `mem::drop`) - rust-lang/rust#147710 (Fix ICE when using contracts on async functions) - rust-lang/rust#147716 (Fix some comments) - rust-lang/rust#147718 (miri: use allocator_shim_contents codegen helper) - rust-lang/rust#147729 (ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius) - rust-lang/rust#147742 (Revert unintentional whitespace changes to rustfmt-excluded file) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polonius liveness has to contain boring locals, and we ignore them in diagnostics, to match NLL diagnostics that never involve any boring locals. When explaining why a borrow contains a point, I ignored these boring locals when it was due to a use of a live var, but forgot to do so when the cause was because of a drop of a live var.
This is what was causing the last two (known) diagnostics differences under the polonius compare-mode:
tests/ui/dropck/dropck_trait_cycle_checked.rstests/ui/unboxed-closures/unboxed-closures-failed-recursive-fn-1.rsr? @jackh726