Skip to content

[Deprecated] exhaustivity & redundancy check for pattern matching #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liufengyun wants to merge 11 commits into from
Closed

[Deprecated] exhaustivity & redundancy check for pattern matching #1261

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5cdd42f
initial works
liufengyun May 11, 2016
9a0952c
support check java enum from classfile and source file
liufengyun May 24, 2016
fd1b286
fix false warning about Nil
liufengyun Jun 2, 2016
d681a78
suppress checking of for, try and partial functions
liufengyun Jun 3, 2016
da9511d
add GADT test
liufengyun Jun 11, 2016
89e8ff9
refine patmat check for type erasure
liufengyun Jun 11, 2016
b25e952
add tuple test to patmat check
liufengyun Jun 12, 2016
e2db834
add test t5440 for patmat check
liufengyun Jun 13, 2016
2d6e803
better warning for higher-kinded types and alias types
liufengyun Jun 15, 2016
f69b305
fix SI-9657 about type bounds
liufengyun Jun 23, 2016
c79181d
address counter-example of two unrelated traits
liufengyun Jul 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
better warning for higher-kinded types and alias types
  • Loading branch information
@liufengyun
liufengyun committed Jul 5, 2016
commit 2d6e80348ad06a3bb60e9b314e5a257f74f36186
7 changes: 5 additions & 2 deletions src/dotty/tools/dotc/transform/patmat/Space.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import ast.tpd
import core.Decorators._
import core.TypeApplications._
import core.Symbols._
import core.StdNames._
import core.NameOps._
import core.Constants._

Expand Down Expand Up @@ -401,7 +402,8 @@ class SpaceEngine(implicit ctx: Context) extends SpaceLogic {
case tp: ThisType => refine(tp.tref)
case tp: NamedType =>
val pre = refinePrefix(tp.prefix)
if (pre.isEmpty) tp.name.show.stripSuffix("$")
if (tp.name == tpnme.hkApply) pre
else if (pre.isEmpty) tp.name.show.stripSuffix("$")
else pre + "." + tp.name.show.stripSuffix("$")
case _ => tp.show.stripSuffix("$")
}
Expand Down Expand Up @@ -472,7 +474,8 @@ class SpaceEngine(implicit ctx: Context) extends SpaceLogic {

def checkExhaustivity(_match: Match): Unit = {
val Match(sel, cases) = _match
val selTyp = sel.tpe.widen.elimAnonymousClass
val selTyp = sel.tpe.widen.elimAnonymousClass.dealias


val patternSpace = cases.map(x => project(x.pat)).reduce((a, b) => Or(List(a, b)))
val uncovered = simplify(minus(Typ(selTyp, true), patternSpace))
Expand Down