-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Deprecated] exhaustivity & redundancy check for pattern matching #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+3,321
−25
Closed
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5cdd42f
initial works
liufengyun 9a0952c
support check java enum from classfile and source file
liufengyun fd1b286
fix false warning about Nil
liufengyun d681a78
suppress checking of for, try and partial functions
liufengyun da9511d
add GADT test
liufengyun 89e8ff9
refine patmat check for type erasure
liufengyun b25e952
add tuple test to patmat check
liufengyun e2db834
add test t5440 for patmat check
liufengyun 2d6e803
better warning for higher-kinded types and alias types
liufengyun f69b305
fix SI-9657 about type bounds
liufengyun c79181d
address counter-example of two unrelated traits
liufengyun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refine patmat check for type erasure
- Loading branch information
commit 89e8ff917826529890b10aa157634cbe4c15e4ef
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| trait B | ||
| class D extends B | ||
| object Test extends App { | ||
| def foo[T](bar: T) = { | ||
| bar match { | ||
| case _: Array[Array[_]] => println("array 2d") | ||
| case _: Array[_] => println("array 1d") | ||
| case _ => println("something else") | ||
| } | ||
| } | ||
| foo(Array.fill(10)(2)) | ||
| foo(Array.fill(10, 10)(2)) | ||
| foo(Array.fill(10, 10, 10)(2)) | ||
| foo(List(1, 2, 3)) | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
counter-example
I propose to use real erasure:
TypeErasure.erasure(tp)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is addressed in the new PR by handling AND and OR-types explicitly.
TypeErasurecan't be simply reused here as I don't wantInt | Booleanget erased toObjectand theprefixinTypeRefremoved.