Skip to content

[Deprecated] exhaustivity & redundancy check for pattern matching #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liufengyun wants to merge 11 commits into from
+3,321 −25
Closed

[Deprecated] exhaustivity & redundancy check for pattern matching #1261

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5cdd42f
initial works
liufengyun May 11, 2016
9a0952c
support check java enum from classfile and source file
liufengyun May 24, 2016
fd1b286
fix false warning about Nil
liufengyun Jun 2, 2016
d681a78
suppress checking of for, try and partial functions
liufengyun Jun 3, 2016
da9511d
add GADT test
liufengyun Jun 11, 2016
89e8ff9
refine patmat check for type erasure
liufengyun Jun 11, 2016
b25e952
add tuple test to patmat check
liufengyun Jun 12, 2016
e2db834
add test t5440 for patmat check
liufengyun Jun 13, 2016
2d6e803
better warning for higher-kinded types and alias types
liufengyun Jun 15, 2016
f69b305
fix SI-9657 about type bounds
liufengyun Jun 23, 2016
c79181d
address counter-example of two unrelated traits
liufengyun Jul 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add tuple test to patmat check
  • Loading branch information
@liufengyun
liufengyun committed Jul 5, 2016
commit b25e9526cbc43e5a5d7c5c07715d157a5bc0ac82
8 changes: 7 additions & 1 deletion src/dotty/tools/dotc/transform/patmat/Space.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,13 @@ class SpaceEngine(implicit ctx: Context) extends SpaceLogic {
}

// refine path-dependent type in params. refer to t9672
meth.firstParamTypes.map(_.stripTypeVar).map(refine(tp, _))
meth.firstParamTypes.map(_.stripTypeVar).map { ptp =>
(tp, ptp) match {
case (TypeRef(ref1: TypeProxy, _), TypeRef(ref2: TypeProxy, name)) =>
if (ref1.underlying <:< ref2.underlying) TypeRef(ref1, name) else ptp
Copy link
Contributor

@DarkDimius DarkDimius Jul 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. this is kind-of asSeenFrom.

case _ => ptp
}
}
}

def partitions(tp: Type): List[Space] = {
Copy link
Contributor

@DarkDimius DarkDimius Jul 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decompose

Copy link
Contributor

@DarkDimius DarkDimius Jul 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment that says that there is an assumption that canDecompose(tp)

Expand Down
5 changes: 5 additions & 0 deletions tests/patmat/tuple.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
object Test {
(4, (4, 6)) match {
case (x, (y, z)) => true
}
}