Skip to content

Conversation

@francoism90
Copy link

@francoism90 francoism90 commented Sep 24, 2020

When using ->paginate() or ->jsonPaginate(), it seems it doesn't inject the appends when needed.
This should fix #531.

This does work, but please let me know if the code can improved. :)

Copy link
Contributor

@dominikb dominikb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Does it make sense to add a test for this?

@francoism90
Copy link
Author

@dominikb Thanks for your review. :)

It would be great if this could be merged, this is the only showstopper for upgrading to L8.

@francoism90
Copy link
Author

@freekmurze Sorry, but will this ever be merged/fixed? It seems I'm not the only one having this issue and I'm only waiting for this fix or I need to downgrade the package to v2.

@freekmurze
Copy link
Member

@francoism90 please have a little patience. We'll handle this we have some time. There are a lot of other issues and client projects that require our attention as well.

@francoism90 can you add a test that is fixed by this PR. This will ensure that we don't break this behaviour again.

@francoism90
Copy link
Author

francoism90 commented Sep 30, 2020

@freekmurze Sorry, I do understand client project have priority and I'm glad Spatie is maintaining so many open-source projects. :)

@freekmurze I have added tests for collections and paginates, they do work (and fail when needed), but maybe this should be done in a better way. Please let me know!

@freekmurze freekmurze merged commit d673d21 into spatie:master Sep 30, 2020
@freekmurze
Copy link
Member

Thanks for your work on this! 👍

@francoism90
Copy link
Author

@freekmurze Thanks for the merge! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

whenAppended no longer working

3 participants