Skip to content

Add LengthAwarePaginator to QueryBuilder #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Add LengthAwarePaginator to QueryBuilder #532

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c203a23
Add LengthAwarePaginator
Sep 24, 2020
e4f4a49
Add paginates & collections tests
Sep 30, 2020
642c14c
Fix AppendTest
Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add LengthAwarePaginator
  • Loading branch information
francoism90 committed Sep 24, 2020
commit c203a23683e17e96a22faaec1444a1ffa358faa7
5 changes: 5 additions & 0 deletions src/QueryBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\Relation;
use Illuminate\Http\Request;
use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\Support\Collection;
use Illuminate\Support\Traits\ForwardsCalls;
use Spatie\QueryBuilder\Concerns\AddsFieldsToQuery;
Expand Down Expand Up @@ -113,6 +114,10 @@ public function __call($name, $arguments)
$this->addAppendsToResults($result);
}

if ($result instanceof LengthAwarePaginator) {
$this->addAppendsToResults(collect($result->items()));
}

return $result;
}

Expand Down