Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/QueryBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\Relation;
use Illuminate\Http\Request;
use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\Support\Collection;
use Illuminate\Support\Traits\ForwardsCalls;
use Spatie\QueryBuilder\Concerns\AddsFieldsToQuery;
Expand Down Expand Up @@ -113,6 +114,10 @@ public function __call($name, $arguments)
$this->addAppendsToResults($result);
}

if ($result instanceof LengthAwarePaginator) {
$this->addAppendsToResults(collect($result->items()));
}

return $result;
}

Expand Down
45 changes: 45 additions & 0 deletions tests/AppendTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@

namespace Spatie\QueryBuilder\Tests;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Http\Request;
use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\Support\Collection;
use Spatie\QueryBuilder\Exceptions\InvalidAppendQuery;
use Spatie\QueryBuilder\QueryBuilder;
use Spatie\QueryBuilder\Tests\TestClasses\Models\AppendModel;
Expand Down Expand Up @@ -48,6 +51,28 @@ public function it_can_append_case_insensitive()
$this->assertAttributeLoaded($model, 'fullname');
}

/** @test */
public function it_can_append_collections()
{
$models = $this
->createQueryFromAppendRequest('FullName')
->allowedAppends('fullname')
->get();

$this->assertCollectionAttributeLoaded($models, 'fullname');
}

/** @test */
public function it_can_append_paginates()
{
$models = $this
->createQueryFromAppendRequest('FullName')
->allowedAppends('fullname')
->paginate();

$this->assertPaginateAttributeLoaded($models, 'fullname');
}

/** @test */
public function it_guards_against_invalid_appends()
{
Expand Down Expand Up @@ -114,4 +139,24 @@ protected function assertAttributeLoaded(AppendModel $model, string $attribute)
{
$this->assertTrue(array_key_exists($attribute, $model->toArray()));
}

protected function assertCollectionAttributeLoaded(Collection $collection, string $attribute)
{
$hasModelWithoutAttributeLoaded = $collection
->contains(function (Model $model) use ($attribute) {
return ! array_key_exists($attribute, $model->toArray());
});

$this->assertFalse($hasModelWithoutAttributeLoaded, "The `{$attribute}` attribute was expected but not loaded.");
}

protected function assertPaginateAttributeLoaded(LengthAwarePaginator $collection, string $attribute)
{
$hasModelWithoutAttributeLoaded = $collection
->contains(function (Model $model) use ($attribute) {
return ! array_key_exists($attribute, $model->toArray());
});

$this->assertFalse($hasModelWithoutAttributeLoaded, "The `{$attribute}` attribute was expected but not loaded.");
}
}