Skip to content

Conversation

@Myzhar
Copy link
Member

@Myzhar Myzhar commented Sep 15, 2023

Port to ROS Wrapper the main improvements from the ROS 2 Wrapper

@Myzhar Myzhar requested a review from mattrouss September 15, 2023 13:00
mattrouss

This comment was marked as duplicate.

Copy link
Contributor

@mattrouss mattrouss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When setting the depth mode to NONE in common.yaml, the 3D features are not visible in the rviz sample as expected. However the video view does not display the video as depicted here:

image

I can also reproduce in the ROS 2 rviz sample as well. Is it possible to still have the video view with depth_mode = NONE? It seems like the camera is not working, but the image topics do actually work.

@Myzhar
Copy link
Member Author

Myzhar commented Sep 20, 2023

That's a correct behavior. You must change Fixed frame to <camera_name>_camera_base_link or to base_link because map and odom frames are not published.
Otherwise you can change the image viewer module to use the other one that does not require and existing frame id

@mattrouss
Copy link
Contributor

Instead of changing the module entirely, would it be possible to set the frame to base_link only for the camera module? And will doing so impact the display of the other modules like object detection or skeleton tracking?

@Myzhar
Copy link
Member Author

Myzhar commented Sep 20, 2023

That's not the usual way of using RVIZ. I prefer to leave it to map which is good in any case.
If a user disables depth RVIZ is not useful, there are other tools to visualize only images.

@mattrouss
Copy link
Contributor

Can you update the camera viewer to not show the IMU pose by default ? It does not add much and is a bit disturbing

image

@Myzhar
Copy link
Member Author

Myzhar commented Sep 20, 2023

Yes

@Myzhar
Copy link
Member Author

Myzhar commented Sep 20, 2023

Modification pushed, but it's in the repository zed-ros-examples, not this

@Myzhar Myzhar merged commit 8833d25 into master Sep 20, 2023
@Myzhar Myzhar deleted the update_wrapper branch September 20, 2023 12:50
@Myzhar Myzhar mentioned this pull request Oct 6, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants