-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
UI: Visual focus indicators (VFIs) aren't visible in high contrast mode (rebase) #31848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The original CI results are so old I can no longer find them in CircleCI. Re-running CI to find what's left to do after the rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 4b6aac1.
☁️ Nx Cloud last updated this comment at |
|
@MichaelArestad Can you take a look on Windows? :) |
|
@valentinpalkovic Phew! Tested it! This a notable improvement. We certainly have work to do in high contrast mode. Ship it! |
jonniebigodes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran some tests on this and it's working. And agree with @MichaelArestad.
@valentinpalkovic all is good on my end and @Sidnioulz thank you for taking the time to follow up on this 🙏
Closes #25935
What I did
Rebase of #29239. The original PR was approved by @MichaelArestad. The PR was left without review for ~9 months but seemed finished overall, so I'm helping it reach a mergeable state.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Caution
This does not appear to be testable automatically (see StackOverflow).
Manual testing
@MichaelArestad could you please confirm if you had completed manual testing as part of your review?
Documentation
N/A
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Improves accessibility by adding Windows high contrast mode support across core UI components, ensuring focus indicators remain visible when system high contrast is enabled.
code/addons/docs/src/blocks/controls/Boolean.tsxfor visible state indicatorscode/core/src/components/components/ActionBar/ActionBar.tsxusing system highlight colorscode/core/src/components/components/form/input/input.tsxwhile preserving existing focus styles