Skip to content

Conversation

@ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented May 30, 2025

Closes #31459

What I did

Introduced a new onboarding feature which is only added for full, interactive installs (not "minimal" or in CI). Removed the addon from generators and instead added a list of supported project types to ensure addon-onboarding is only added for those project types.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Makes the onboarding addon installation conditional, avoiding unnecessary dependencies in minimal Storybook installs.

  • Added skipInstall flag in code/lib/cli-storybook/src/add.ts to control dependency installation during addon setup
  • Improved test configuration handling in Vitest plugin with path normalization via pathe.normalize()
  • Added documentation for preview-only builds with --preview-only flag in CLI options
  • Aligned version numbers across packages from 9.1.0-alpha.1 to 9.1.0-alpha.2
  • Enhanced documentation with comprehensive framework compatibility requirements in docs/get-started/install.mdx

@nx-cloud
Copy link

nx-cloud bot commented May 30, 2025

View your CI Pipeline Execution ↗ for commit c6fe703.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 30s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-03 07:58:29 UTC

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

11 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@shilman shilman added the cli label Jun 3, 2025
@ghengeveld ghengeveld merged commit 96e1c1b into next Jun 3, 2025
57 checks passed
@ghengeveld ghengeveld deleted the conditional-addon-onboarding branch June 3, 2025 08:36
@github-actions github-actions bot mentioned this pull request Jun 3, 2025
19 tasks
@ghengeveld ghengeveld added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 7, 2025
This was referenced Jun 10, 2025
JReinhold pushed a commit that referenced this pull request Jun 10, 2025
CLI: Don't install addon-onboarding during minimal installs
(cherry picked from commit 96e1c1b)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 10, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

76 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@ghengeveld ghengeveld added the needs qa Indicates that this needs manual QA during the upcoming minor/major release label Jul 25, 2025
@yannbf yannbf removed the needs qa Indicates that this needs manual QA during the upcoming minor/major release label Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal cli patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Minimal install still installs addon-onboarding

5 participants