-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Release: Patch 9.0.8 #31732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Patch 9.0.8 #31732
Conversation
Docs: Fix incorrect @next version specifiers
….7, to skip the 9.0.7 release because the eslint plugin was wrongly released as 9.0.7, so we need to skip that release altogether. [skip ci] Co-authored-by: @yannbf <[email protected]>
CLI: Don't install addon-onboarding during minimal installs (cherry picked from commit 96e1c1b)
…-action Addon Docs: Fix SyntaxHighlighter "Copy" button by avoiding potentially mocked clipboard (cherry picked from commit 5ee8cf4)
Docs: Point CSF Factories docs at RFC (cherry picked from commit 1d1f8e0)
…ials-options Automigration: Enhance removeEssentials to convert options (cherry picked from commit 35a7339)
…exports-from-docs AddonDocs: Remove export of blocks (cherry picked from commit 58cb556)
…pinstall Addon-vitest: Fix adding with `--skip-install` failing missing packageJson invariant (cherry picked from commit 505b08f)
Addon Themes: Define missing React dependencies (cherry picked from commit b693bb7)
|
View your CI Pipeline Execution ↗ for commit 24950cd.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
99 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
| const main = await readConfig('main.ts'); | ||
| await moveEssentialOptions(false, { | ||
| docs: false, | ||
| backgrounds: false, | ||
| measure: false, | ||
| outline: false, | ||
| grid: false, | ||
| })(main); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Test should verify that features object didn't exist before the migration. Add an assertion to check the initial state.
| ```shell renderer="common" language="js" packageManager="npm" | ||
| npx storybook migrate csf-2-to-3 --glob="**/*.stories.tsx" --parser=tsx | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Missing JS and JSX file glob patterns. Add additional patterns to catch both TypeScript and JavaScript story files.
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 198 | 198 | 0 |
| Self size | 80 KB | 80 KB | 0 B |
| Dependency size | 31.34 MB | 31.38 MB | 🚨 +39 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/angular
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 208 | 208 | 0 |
| Self size | 606 KB | 606 KB | 0 B |
| Dependency size | 29.74 MB | 29.78 MB | 🚨 +39 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/ember
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 208 | 208 | 0 |
| Self size | 28 KB | 28 KB | 0 B |
| Dependency size | 28.90 MB | 28.94 MB | 🚨 +39 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 534 | 534 | 0 |
| Self size | 216 KB | 216 KB | 0 B |
| Dependency size | 58.88 MB | 58.92 MB | 🚨 +39 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 284 | 284 | 0 |
| Self size | 25 KB | 25 KB | 0 B |
| Dependency size | 43.60 MB | 43.64 MB | 🚨 +39 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/server-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 210 | 210 | 0 |
| Self size | 17 KB | 17 KB | 0 B |
| Dependency size | 32.61 MB | 32.65 MB | 🚨 +39 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 324 | 324 | 0 |
| Self size | 243 KB | 244 KB | 🚨 +714 B 🚨 |
| Dependency size | 97.83 MB | 97.87 MB | 🚨 +40 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 267 | 267 | 0 |
| Self size | 31 KB | 31 KB | 0 B |
| Dependency size | 82.23 MB | 82.27 MB | 🚨 +40 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-react-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 175 | 175 | 0 |
| Self size | 24 KB | 24 KB | 0 B |
| Dependency size | 30.43 MB | 30.47 MB | 🚨 +39 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
This is an automated pull request that bumps the version from
9.0.7to9.0.8.Once this pull request is merged, it will trigger a new release of version
9.0.8.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:--skip-installfailing missing packageJson invariant #31720If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
9.0.8
--skip-installfailing missing packageJson invariant - #31720, thanks @JReinhold!Greptile Summary
Patch release 9.0.8 addressing several addon bugs and improving installation workflows. Major fixes focus on clipboard functionality, dependency management, and installation processes.
--skip-installfailing missing packageJson invariant #31720]