Release: Prerelease 9.1.0-alpha.5 #31726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/storybookjs/storybook into norbert/not-expose-blocks-exports-from-docs
…d configuration updates for Storybook 9. Clarified the new import paths for Blocks and removed deprecated usages. Adjusted formatting in the configuration example.
…/github.com/storybookjs/storybook into norbert/not-expose-blocks-exports-from-docs
… Storybook. Changed examples from `mdx` to `jsx` format and clarified the new import path for `Meta` from `@storybook/addon-docs/blocks`.
…exports-from-docs AddonDocs: Remove export of blocks
github-actions
bot
added
the
release
github-actions
bot
requested review from
jonniebigodes and
kylegach
as code owners
github-actions
bot
added
the
release
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM
21 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
…pinstall Addon-vitest: Fix adding with `--skip-install` failing missing packageJson invariant
storybook-bot
force-pushed
the
version-non-patch-from-9.1.0-alpha.4
branch
from
3a3142c to
f83173b
Compare
CSF: Only add preview annotations to definePreview in csf-factories automigration
storybook-bot
force-pushed
the
version-non-patch-from-9.1.0-alpha.4
branch
from
f83173b to
9520d39
Compare
Addon Themes: Define missing React dependencies
storybook-bot
force-pushed
the
version-non-patch-from-9.1.0-alpha.4
branch
from
9520d39 to
397338d
Compare
kasperpeulen
added
ci:daily
|
View your CI Pipeline Execution ↗ for commit 397338d.
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 397338d.
☁️ Nx Cloud last updated this comment at |
Contributor
There was a problem hiding this comment.
11 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
+106
to
+108
| if (options.configType === 'preview' && !projectAnnotationNames.includes(name)) { | ||
| continue; | ||
| } |
Contributor
There was a problem hiding this comment.
style: Consider extracting options.configType === 'preview' check to a descriptive variable name for better readability and maintainability
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 198 | 198 | 0 |
| Self size | 80 KB | 80 KB | 0 B |
| Dependency size | 31.34 MB | 31.38 MB | 🚨 +39 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 49 | 49 | 0 |
| Self size | 31.40 MB | 31.22 MB | 🎉 -185 KB 🎉 |
| Dependency size | 17.41 MB | 17.41 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/angular
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 208 | 208 | 0 |
| Self size | 606 KB | 606 KB | 0 B |
| Dependency size | 29.74 MB | 29.78 MB | 🚨 +39 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/ember
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 208 | 208 | 0 |
| Self size | 28 KB | 28 KB | 0 B |
| Dependency size | 28.90 MB | 28.94 MB | 🚨 +39 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 534 | 534 | 0 |
| Self size | 216 KB | 217 KB | 🚨 +425 B 🚨 |
| Dependency size | 58.88 MB | 58.91 MB | 🚨 +39 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 284 | 284 | 0 |
| Self size | 25 KB | 25 KB | 0 B |
| Dependency size | 43.60 MB | 43.64 MB | 🚨 +39 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/server-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 210 | 210 | 0 |
| Self size | 17 KB | 17 KB | 0 B |
| Dependency size | 32.61 MB | 32.65 MB | 🚨 +39 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 50 | 50 | 0 |
| Self size | 1 KB | 1 KB | 0 B |
| Dependency size | 48.81 MB | 48.63 MB | 🎉 -185 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 324 | 324 | 0 |
| Self size | 244 KB | 244 KB | 🚨 +141 B 🚨 |
| Dependency size | 97.86 MB | 98.82 MB | 🚨 +960 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 267 | 267 | 0 |
| Self size | 31 KB | 31 KB | 0 B |
| Dependency size | 82.25 MB | 82.11 MB | 🎉 -145 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 1 | 1 | 0 |
| Self size | 11.02 MB | 12.13 MB | 🚨 +1.11 MB 🚨 |
| Dependency size | 98 KB | 98 KB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-react-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 175 | 175 | 0 |
| Self size | 24 KB | 24 KB | 0 B |
| Dependency size | 30.43 MB | 30.47 MB | 🚨 +39 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
9.1.0-alpha.4to9.1.0-alpha.5.Once this pull request is merged, it will trigger a new release of version
9.1.0-alpha.5.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:--skip-installfailing missing packageJson invariant #31720 (will also be patched)If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
9.1.0-alpha.5
--skip-installfailing missing packageJson invariant - #31720, thanks @JReinhold!Greptile Summary
This prerelease contains several critical bug fixes addressing addon dependencies, CSF factory transformations, and package exports in Storybook 9.1.0-alpha.5.
addon-themesbuild failures by adding missing React dependencies for non-React projects incode/addons/themes/package.jsondefinePreviewcalls incode/lib/cli-storybook/src/codemod/helpers/config-to-csf-factory.tsaddon-vitestinstallation with--skip-installflag by properly handling packageJson requirement incode/core/src/common/js-package-manager/JsPackageManager.tsaddon-docsmain entrypoint to improve fast build compatibility