Skip to content

Conversation

@ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Jun 6, 2025

Closes #31651

What I did

Added missing react and react-dom to devDependencies for addon-themes, similar to other addons.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updates @storybook/addon-themes to properly declare React build dependencies by adding missing React packages as devDependencies.

  • Adds react and react-dom to devDependencies in code/addons/themes/package.json for build-time dependencies
  • Fixes build failures in non-React projects (e.g., Svelte) that were encountering "Could not resolve 'react'" errors
  • Aligns with other Storybook addons' dependency management practices by keeping React as a dev-only dependency

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@nx-cloud
Copy link

nx-cloud bot commented Jun 6, 2025

View your CI Pipeline Execution ↗ for commit e9bfa24.

Command Status Duration Result
nx run-many -t check -c production --parallel=7 ✅ Succeeded 1s View ↗
nx run-many -t build -c production --parallel=3 ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-07 07:22:09 UTC

@ghengeveld ghengeveld added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 7, 2025
@storybook-app-bot
Copy link

Package Benchmarks

Commit: e9bfa24, ran on 7 June 2025 at 07:28:34 UTC

The following packages have significant changes to their size or dependencies:

@storybook/cli

Before After Difference
Dependency count 324 324 0
Self size 244 KB 244 KB 0 B
Dependency size 97.79 MB 97.83 MB 🚨 +43 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 267 267 0
Self size 31 KB 31 KB 0 B
Dependency size 82.19 MB 82.23 MB 🚨 +43 KB 🚨
Bundle Size Analyzer Link Link

@ghengeveld ghengeveld merged commit b693bb7 into next Jun 10, 2025
63 of 67 checks passed
@ghengeveld ghengeveld deleted the addon-themes-react-dependency branch June 10, 2025 12:30
JReinhold pushed a commit that referenced this pull request Jun 10, 2025
Addon Themes: Define missing React dependencies

(cherry picked from commit b693bb7)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 10, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: @storybook/addon-themes v9.0.4 has undeclared dependency on React

4 participants