AddonDocs: Remove export of blocks #31724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit ecfdd19.
☁️ Nx Cloud last updated this comment at |
ndelangen
changed the title
ghengeveld
approved these changes
Jun 10, 2025
…/github.com/storybookjs/storybook into norbert/not-expose-blocks-exports-from-docs
…d configuration updates for Storybook 9. Clarified the new import paths for Blocks and removed deprecated usages. Adjusted formatting in the configuration example.
…/github.com/storybookjs/storybook into norbert/not-expose-blocks-exports-from-docs
ndelangen
added
the
patch:yes
… Storybook. Changed examples from `mdx` to `jsx` format and clarified the new import path for `Meta` from `@storybook/addon-docs/blocks`.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM
18 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
This was referenced Jun 10, 2025
Closed
Merged
JReinhold
pushed a commit
that referenced
this pull request
Jun 10, 2025
…exports-from-docs AddonDocs: Remove export of blocks (cherry picked from commit 58cb556)
github-actions
bot
added
the
patch:done
Contributor
There was a problem hiding this comment.
LGTM
18 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
This was referenced Aug 18, 2025
ndelangen
removed
the
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I've removed the re-export of
./blocksfrom the addon docs main entrypoint.Users should be importing blocks from
@storybook/addon-docs/blocksand not from the main entrypoint of addon-docs.The reason this came up, was because of the fast build feature broke due to a user importing a block from addon-docs main entrypoint.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Breaking change that removes block exports from addon-docs main entrypoint to fix fast build feature compatibility issues. Users must now import doc blocks directly from
@storybook/addon-docs/blocksinstead of@storybook/addon-docs.code/addons/docs/src/index.ts, keeping only essential exports (DocsRenderer, DocsTypes)@storybook/addon-docs/blocksdirectly