Repository navigation
Web: keep a picked file on the document and slide that asked for it - #479
Merged
h-a-n-a-s-h-i merged 1 commit intoOct 14, 2026
Merged
Conversation
The browser file picker only queued a name and bytes. When the read finished, DeckCraft guessed the command and ran it on whichever document and slide were active, so a picture, sound or outline could land in the wrong place, and a later pick could finish first. The request now keeps the document, the slide or master, the operation and a cancellation id. A completion applies there, or is dropped when that target is gone or the picker was dismissed. Co-authored-by: Cursor <cursoragent@cursor.com>
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 14, 2026
…aster views (#479) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 14, 2026
Member
|
Thank you for this contribution, @NikitkaRa! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
3 of 4 tasks
anishguduru
pushed a commit
to anishguduru/deckcraft
that referenced
this pull request
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The browser file picker queued only a file name and its bytes. When the read finished, DeckCraft guessed the command from the name and ran it on whichever document and slide were active. Switching slides or presentations while a file was being read, or having two picks finish out of order, could insert a picture, sound, video or outline into the wrong place.
A pick or a drop now records the document, the slide (or master/layout), the operation that was requested, and a cancellation id. The file is applied to that target when it arrives. If the presentation or slide is gone, or the picker was dismissed, the file is dropped instead of landing in whatever is open.
Test plan
cargo test -p deckcraft-ui-egui --lib inbox_testscovers a picture and an audio clip finishing in reverse order after a slide and document change, an outline staying on the document that opened it, a video request that does not insert a PNG as a picture, a deleted slide, a closed presentation, a dismissed picker, and a dropcargo clippy -p deckcraft-ui-egui --all-targets -- -D warningscargo fmt --all -- --check,cargo xtask assets,cargo xtask layerscargo check -p deckcraft-web --target wasm32-unknown-unknownandcargo check -p deckcraft-ui-egui --target wasm32-unknown-unknownCloses #414