Gicv3#183
Merged
Merged
Conversation
ken4647
reviewed
Mar 11, 2025
| use crate::{irq::IrqHandler, mem::phys_to_virt}; | ||
| #[cfg(not(feature = "gic-v3"))] | ||
| use arm_gic::gic_v2::{GicCpuInterface, GicDistributor}; | ||
| #[cfg(feature = "gic-v3")] |
Contributor
There was a problem hiding this comment.
I think this file should be seperated into two file as "gicv2.rs" and "gicv3.rs", and mod their pub interface (such as set_enable and dispatch_irq) via "mod.rs" or `"lib.rs".
| @@ -0,0 +1,121 @@ | |||
| import subprocess | |||
Contributor
There was a problem hiding this comment.
why this file moved from directory script?
Contributor
Author
There was a problem hiding this comment.
This file is from @coolyjg 's repo, should I keep it?
Contributor
There was a problem hiding this comment.
No need to keep it, just recover the directories
| let pl011_base = ruxdtb::get_pl011_base(); | ||
| info!("pl011_base: 0x{:x}", pl011_base); | ||
| let pl031_base = ruxdtb::get_pl031_base(); | ||
| info!("pl031_base: 0x{:x}", pl031_base); |
Contributor
There was a problem hiding this comment.
Are these code suitable for other architecture such as x86 or riscv64? as pl011 and pl031 are not the devices for them.
lhw2002426
force-pushed
the
gicv3
branch
10 times, most recently
from
2baa6aa to
f58e0c7
Compare
ken4647
approved these changes
Mar 13, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.