Skip to content

Allowing NewClassTree to be passed into getGenericParameterNullnessAtInvocation #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msridhar merged 14 commits into from
May 10, 2025
Merged

Allowing NewClassTree to be passed into getGenericParameterNullnessAtInvocation #1210

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7cb0f47
tests
msridhar Apr 11, 2025
cf31bd4
generalised getGenericParameterNullnessAtInvocation to allow NewClass…
dhruv-agr May 2, 2025
7b4ed8e
Ensure classes null-marked by library model detected in all places (#…
msridhar Apr 13, 2025
23e2e39
JSpecify: handle varargs whose element type is a type variable (#1200)
msridhar Apr 18, 2025
6418675
Update to Error Prone 2.38.0 (#1203)
msridhar Apr 23, 2025
ffe4daa
Optimization to annotation stripping in library model matching (#1204)
msridhar Apr 28, 2025
22065a0
Make arg position nullness array contents nullable (#1207)
msridhar Apr 28, 2025
9d9a008
Properly handle method references to null-unmarked methods (#1205)
msridhar Apr 30, 2025
d9bc50d
Prepare for release 0.12.7.
yuxincs Apr 30, 2025
b13f90a
Prepare next development version.
yuxincs Apr 30, 2025
edda5b9
Document interactions between Guava and JSpecify mode in README (#1208)
msridhar Apr 30, 2025
c78b667
PR 1210 review changes
dhruv-agr May 9, 2025
2e0cf89
Merge branch 'master' into issue-1155
msridhar May 10, 2025
bdafabe
tweaks
msridhar May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tests
  • Loading branch information
@msridhar
msridhar committed Apr 11, 2025
commit 7cb0f47f3ec0e1b9be3df7fd728e3293689c1a4e
39 changes: 39 additions & 0 deletions nullaway/src/test/java/com/uber/nullaway/jspecify/GenericsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2324,6 +2324,45 @@ public void issue1129() {
.doTest();
}

@Test
public void callWithConstructorReceiver() {
makeHelper()
.addSourceLines(
"Test.java",
"import org.jspecify.annotations.NullMarked;",
"import org.jspecify.annotations.Nullable;",
"@NullMarked",
"public class Test {",
" private static class Inner<T extends @Nullable Object> {",
" Inner<T> identity() { return this; }",
" }",
" Inner<@Nullable Object> mThing = new Inner<@Nullable Object>().identity();",
"}")
.doTest();
}

@Test
public void newNullableWithArg() {
makeHelper()
.addSourceLines(
"Test.java",
"import org.jspecify.annotations.NullMarked;",
"import org.jspecify.annotations.Nullable;",
"@NullMarked",
"public class Test {",
" private static class Wrapper<T extends @Nullable String> {",
" private final T value;",
" Wrapper(T value) {",
" this.value = value;",
" }",
" }",
" Wrapper<@Nullable String> testConstructorCall() {",
" return new Wrapper<@Nullable String>(null);",
" }",
"}")
.doTest();
}

@Test
public void issue1156() {
makeHelper()
Expand Down