Allowing NewClassTree to be passed into getGenericParameterNullnessAtInvocation#1210
Merged
msridhar merged 14 commits intouber:masterfrom May 10, 2025
Merged
Allowing NewClassTree to be passed into getGenericParameterNullnessAtInvocation#1210msridhar merged 14 commits intouber:masterfrom
msridhar merged 14 commits intouber:masterfrom
Conversation
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1210 +/- ##
=========================================
Coverage 88.28% 88.29%
- Complexity 2344 2347 +3
=========================================
Files 89 89
Lines 7643 7652 +9
Branches 1528 1531 +3
=========================================
+ Hits 6748 6756 +8
Misses 450 450
- Partials 445 446 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msridhar
reviewed
May 5, 2025
Collaborator
msridhar
left a comment
msridhar
left a comment
There was a problem hiding this comment.
Looking good! I have a few comments
| .doTest(); | ||
| } | ||
|
|
||
| @Ignore |
Collaborator
There was a problem hiding this comment.
Do we have an issue now where we track this case?
…ber#1197) Fixes uber#1194 Previously we were sloppy about allowing a null `Handler` to be passed into `CodeAnnotationInfo` and then caching the result. Here we change the code to always pass a non-null `Handler` in to public APIs of `CodeAnnotationInfo`, and we avoid caching if the handler is ever `null` from an internal call.
…1200) Partially addresses uber#1199. After substituting for a type variable, we were not retrieving the correct nullability for a varargs parameter, which should be the nullability of the component, not the array type itself. Also adds some simplification of our handling of varargs calls based on a tip from @jeffrey-easyesi
Fixes uber#1195 We adjust our method overriding checks for a method reference to a `@NullUnmarked` method. Any overriding should be allowed, except in the presence of a restrictive annotation (`@Nullable` on the return or `@NonNull` on a parameter). Also add tests for `@NonNull` on the varargs parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unit test: newNullableWithArg()
Generalised the parameters of getGenericParameterNullnessAtInvocation to accept NewClassTree
Fixes #1214