Skip to content

Allowing NewClassTree to be passed into getGenericParameterNullnessAtInvocation #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msridhar merged 14 commits into from
May 10, 2025
Merged

Allowing NewClassTree to be passed into getGenericParameterNullnessAtInvocation #1210

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7cb0f47
tests
msridhar Apr 11, 2025
cf31bd4
generalised getGenericParameterNullnessAtInvocation to allow NewClass…
dhruv-agr May 2, 2025
7b4ed8e
Ensure classes null-marked by library model detected in all places (#…
msridhar Apr 13, 2025
23e2e39
JSpecify: handle varargs whose element type is a type variable (#1200)
msridhar Apr 18, 2025
6418675
Update to Error Prone 2.38.0 (#1203)
msridhar Apr 23, 2025
ffe4daa
Optimization to annotation stripping in library model matching (#1204)
msridhar Apr 28, 2025
22065a0
Make arg position nullness array contents nullable (#1207)
msridhar Apr 28, 2025
9d9a008
Properly handle method references to null-unmarked methods (#1205)
msridhar Apr 30, 2025
d9bc50d
Prepare for release 0.12.7.
yuxincs Apr 30, 2025
b13f90a
Prepare next development version.
yuxincs Apr 30, 2025
edda5b9
Document interactions between Guava and JSpecify mode in README (#1208)
msridhar Apr 30, 2025
c78b667
PR 1210 review changes
dhruv-agr May 9, 2025
2e0cf89
Merge branch 'master' into issue-1155
msridhar May 10, 2025
bdafabe
tweaks
msridhar May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Document interactions between Guava and JSpecify mode in README (#1208) 
Fixes #1193
  • Loading branch information
@msridhar @dhruv-agr
msridhar authored and dhruv-agr committed May 9, 2025
commit edda5b969d9ce370ece7d5abb206501aab25c53d
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ Some annotation processors like [Dagger](https://google.github.io/dagger/) and [

**Note for Dagger users**: Dagger versions older than 2.12 can have bad interactions with NullAway; see [here](https://github.com/uber/NullAway/issues/48#issuecomment-340018409). Please update to Dagger 2.12 to fix the problem.

#### JSpecify Mode / Guava

As of version 33.4.1, [Guava](https://github.com/google/guava) uses [JSpecify](https://jspecify.dev) `@NullMarked` annotations for most of its packages, and hence NullAway will treat those packages as annotated by default. This treatment may lead to some false positives (due to handling of type variables), which can be mitigated by running NullAway in its (under-development) JSpecify mode. See [the wiki docs on JSpecify support](https://github.com/uber/NullAway/wiki/JSpecify-Support) for more details.

#### Lombok

Unlike other annotation processors above, Lombok modifies the in-memory AST of the code it processes, which is the source of numerous incompatibilities with Error Prone and, consequently, NullAway.
Expand Down