Contexts update to upstream, add test, bugfixes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'transaction' and 'breadcrumbs' in event transaction: https://docs.sentry.io/development/sdk-dev/event-payloads/#optional-attributes breadcrumbs: https://docs.sentry.io/development/sdk-dev/event-payloads/breadcrumbs/
…try#42) 1. dsn may specify non-regular port 2. dsn may contains some paths before the projectID
* Add pedantic and analysis options * Fix analysis warnings
- [x] Refactor to support browser + `SentryClient` from `package:sentry/sentry.dart` with conditional import + `SentryBrowserClient` for web from `package:sentry/browser_client.dart` + `SentryIOClient` for VM and Flutter from `package:sentry/io_client.dart` - [x] Write test for browser - [x] Working Angular Sentry packages => https://github.com/leftyio/angular_sentry Main implementation differences are: - gzip compression is provided implicitly by the browser - javascript stacktraces need to be prefix with `window.location.origin` to be resolve by Sentry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the contexts branch updated to current Sentry plugin master branch, adds a test for the contexts functionality and fixes a couple of small bugs identified by the test.