-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Environment API #14306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment API #14306
Conversation
🦋 Changeset detectedLatest commit: 98144fb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
15a3eab to
c701fe4
Compare
CodSpeed Performance ReportMerging #14306 will not alter performanceComparing Summary
Footnotes |
* refactor: use environments to load modules (#14191) * refactor: make `App` more extensible using `BaseApp` (#14197) * refactor: App to extends the new BaseApp (#14213) * refactor: manifest as virtual module (#14298) * refactor: create `generate` when needed * fix type * remove type * fix types * fix breakage of code
* Use separate env to load content config * Format
* feat(cloudflare): add Vite plugin * Skip request handling when running in cloudflare * Skip lots of plugins in non-runnable envs * Use serialized-manifest * Use separate env to load content config * Format * fix rebase * fix type * Remove overrides * Remove trace --------- Co-authored-by: Emanuele Stoppa <[email protected]>
…14345) * refactor: dev app without settings and loader * address comments * chore: refactor to use proper dev pipeline * revert changes * chore: update lockfile * conditionally propagate metadata * revert exports
* Add support for content layer in env API * Lint * Format
* Support CF Images binding * Add support for content layer in env API * Lint * Format * Use image binding in dev --------- Co-authored-by: Samuel Macleod <[email protected]> Co-authored-by: Alexander Niebuhr <[email protected]>
This gets framework components to render in workerd. SSR and client both work.
…t being processed by Vite (#14939)
* Fix astro:env tests in Cloudflare This fixes astro:env tests and brings back .dev.vars support * fix wrangler * log parse errors of .dev.vars
|
@sarah11918 The changesets in this PR are ready to review, along with the upgrade guide docs which are here: withastro/docs#12809 Thanks! |
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviews for astro major changesets, before GitHub dies on me!
Note: we decided that changelog entries for breaking changes would be minimal and link to the upgrade guide for all explanation of changes. So if there is anything contained here that you think needs to be said, it needs to find its way into the upgrade guide!
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest of the changesets reviewed with suggestions! 🙌
(Mostly, the integrations and adapters dont get their own upgrade guides, so we DO rely on changelogs for them. So, these are still hefty entries, and for majors with breaking change, we'll add a #### What should I do? section to make sure it's clear that there is something they might have to do.
|
|
||
| The `createExports()` function has been replaced with a direct export pattern. If you're using a custom `entryPoint` in your Cloudflare adapter config, update your worker file from: | ||
|
|
||
| ```ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarity, can you add a title to this file (and the following)?
| '@astrojs/cloudflare': minor | ||
| --- | ||
|
|
||
| Adds support for `astro preview` command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one looks great!
|
|
||
| to: | ||
|
|
||
| ```ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same file title here as the previous example
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
…o feat/environment-api
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for changesets! If there happen to be any new error messages associated with this, let me know (I didn't immediately see any).
Otherwise, we're pretty close to getting the docs PR squared away and just letting you know that doesn't have to hold up this PR if it's helpful to get it off your plate!
The main thing we want to ensure is that any changesets here merge with correct links to the upgrade guide. Since we've already worked out those what those will be, we know the links for adding here, and that's good enough for me.
(The docs PR is close, just updating other pages in docs to match the changes, and doesn't need to merge before/with this PR since no one is actually relying on them for anything yet.)
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: matthewp <[email protected]>
|
Also noting that the Docs PR is now approved by me and by Armand! Anyone is welcome to give it a final look over for anything you spot last minute! |
Ready to be merged. Fully approved!
Changes
Testing
Docs