view transitions: fix Firefox e2e tests for playwright 1.57 #15113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
|
|
||
| test('fallback triggers animation if not skipped', async ({ page, astro, browserName }) => { | ||
| test.skip(browserName !== 'firefox', 'Only makes sense for browser that uses fallback'); | ||
| test.skip(browserName !== 'some-browser-that-does-not-support-native-view-transitions', 'Only makes sense for browser that uses fallback'); |
Member
There was a problem hiding this comment.
Would it make sense to do test.skip on line 1724 with a comment instead? Since it will never run and stay as documentation basically
Member
Author
There was a problem hiding this comment.
I thought that already has been the most beautiful way to comment just that ;-)
Thank you for the suggestion, Florian! Changed it.
Merged
florian-lefebvre
added a commit
that referenced
this pull request
Jan 7, 2026
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Emanuele Stoppa <[email protected]> Co-authored-by: Matt Kane <[email protected]> Co-authored-by: Matthew Phillips <[email protected]> Co-authored-by: Matthew Phillips <[email protected]> Co-authored-by: Florian Lefebvre <[email protected]> Co-authored-by: Erika <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: Armand Philippot <[email protected]> Co-authored-by: Antony Faris <[email protected]> Co-authored-by: Erika <[email protected]> Co-authored-by: Chris Swithinbank <[email protected]> Co-authored-by: Houston (Bot) <[email protected]> Co-authored-by: Florian Lefebvre <[email protected]> Co-authored-by: Volpeon <[email protected]> Co-authored-by: Martin Trapp <[email protected]> Co-authored-by: fkatsuhiro <[email protected]> Co-authored-by: Oliver Speir <[email protected]> Co-authored-by: Andreas Deininger <[email protected]> Co-authored-by: Roman <[email protected]> Co-authored-by: fabon <[email protected]> Co-authored-by: Raanelom <[email protected]> Co-authored-by: Rahul Dogra <[email protected]> fix(ci): Reinstall deps after having published VS Code (#14996) fix(svelte): allow client directives (#15004) fix(assets): Fixes missing format option for svgs in the passthrough service (#14987) fix(deps): update all non-major dependencies (#15020) fix(content-layer): Try a smarter solution to normalize bare image paths in JSON (#15028) fix(astro): assets vite build log (#15034) resolved (#15033) fix: Remote images: Prevent internal caching from interfering with Astro's cache (#14954) fix(deps): update astro adapters (#15084) fix(deps): update all non-major dependencies (#15072) fix(deps): update astro client runtimes (#15085) fix: move ts-plugin node_modules to dist (#15083) fix: components imports paths (#15107) fix(assets): Use Vite's isFileLoadingAllowed to check if a file can be loaded (#15052) fix(vscode): Correctly handle TypeScript blocks ending with types (#15109) fix(svelte): improve Svelte children prop type checking (#15070) fix Firefox e2e tests for playwright 1.57 (#15113) fix(deps): update astro dependencies (#15103) fix: lint vt test (#15114) fix(deps): update language tools (#15104) resolver abstraction (#15111) fix(vue): add HTML attributes to generated TypeScript types (#15016) Fixes #14686
matthewp
added a commit
that referenced
this pull request
Jan 12, 2026
* fix(ci): Reinstall deps after having published VS Code (#14996) * fix(svelte): allow client directives (#15004) * fix(assets): Fixes missing format option for svgs in the passthrough service (#14987) * fix(assets): Fixes missing format option for svgs in the passthrough service * fix: wtf is going on * chore: changeset * [ci] format * chore: auto format next (#15009) * chore(deps): update github-actions (#15019) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update all non-major dependencies (#15020) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Support extending the image API props type (#15014) * [ci] release (#14997) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix(content-layer): Try a smarter solution to normalize bare image paths in JSON (#15028) * fix(content-layer): Try a smarter solution to normalize bare image paths in JSON * chore: changeset * [ci] format * chore: document core/infra architecture (#14815) Co-authored-by: Emanuele Stoppa <[email protected]> Co-authored-by: Matt Kane <[email protected]> Co-authored-by: Matthew Phillips <[email protected]> Co-authored-by: Matthew Phillips <[email protected]> * [ci] format * fix(astro): assets vite build log (#15034) * chore(sitemap): migrate to astro:routes:resolved (#15033) * fix: Remote images: Prevent internal caching from interfering with Astro's cache (#14954) Co-authored-by: Florian Lefebvre <[email protected]> * [ci] format * Update font utility dependencies to use lighter versions (#15055) * Update font utility dependencies to use lighter versions * Add changeset * skip flaky view transitions redirect test (#15060) * chore(deps): update actions-cool/issues-helper action to v3.7.5 (#15071) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * ClientRouter: Preserve hash fragment during redirects (#15088) * try resurrecting a flaky test (#15089) * fix(deps): update astro adapters (#15084) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update all non-major dependencies (#15072) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update astro client runtimes (#15085) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: move ts-plugin node_modules to dist (#15083) * fix: move ts-plugin node_modules to dist * add: changeset * [ci] format * Update image-size (#15105) * fix: components imports paths (#15107) * Tailwind example, README.md: update link (#15099) * fix(assets): Use Vite's isFileLoadingAllowed to check if a file can be loaded (#15052) * fix(assets): Use Vite's isFileLoadingAllowed to check if a file can be loaded * test: add * fix: windwos perhaos? * chore: changeset * [ci] format * Update prettier extension to new one (#15108) * fix(vscode): Correctly handle TypeScript blocks ending with types (#15109) * fix(vscode): Correctly handle TypeScript blocks ending with types * chore: changeset * [ci] format * fix(svelte): improve Svelte children prop type checking (#15070) * chore: Replace fast-glob with tinyglobby in language server (#15057) * chore: Replace fast-glob with tinyglobby in language server * Use `expandDirectories` option for compatibility with fast-glob * Update packages/language-tools/language-server/src/check.ts --------- Co-authored-by: Erika <[email protected]> * view transitions: fix Firefox e2e tests for playwright 1.57 (#15113) * fix(deps): update astro dependencies (#15103) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Florian Lefebvre <[email protected]> * fix: lint vt test (#15114) * [ci] format * fix(deps): update language tools (#15104) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Florian Lefebvre <[email protected]> * Feature/allow node 24 vercel adapter (#15116) * feat(fonts): new font resolver abstraction (#15111) * [ci] format * feat(fonts)!: upgrade unifont and support formats (#15117) Co-authored-by: Sarah Rainsberger <[email protected]> * fix(vue): add HTML attributes to generated TypeScript types (#15016) * fix(vue): add HTML attributes to generated TypeScript types Fixes #14686 * fix: add package exports and update tests for HTML attributes support * test(vue): add astro check test for HTML attributes Add test fixture and test case to verify that Vue components correctly accept HTML attributes (class, style, id, data-*) and client directives via astro check. Follows the same pattern as the Svelte integration tests. * chore: update lockfile for vue prop-types fixture * feat: deduplicate context types (#15122) Co-authored-by: Armand Philippot <[email protected]> * perf(astro): group chunks on emit (#15123) Co-authored-by: Florian Lefebvre <[email protected]> Co-authored-by: matthewp <[email protected]> Co-authored-by: florian-lefebvre <[email protected]> Co-authored-by: ematipico <[email protected]> * feat(fonts): clean types (#15118) * [ci] release (#15031) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix(vscode): Don't update @types/vscode automatically (#15131) * fix(vscode): Don't update @types/vscode automatically * chore: changeset * fix: adjust page warning to only show up in more relevant times (#15127) * fix: adjust page warning to only show up in more relevant times * chore: changeset * [ci] format * Update security contacts list (#15143) * fix(dev): preserve query params when base path is stripped (#15124) Co-authored-by: Florian Lefebvre <[email protected]> * fix(assets): hoist ?? inside JSON.stringify in virtual module codegen (#15140) * fix(assets): hoist nullish coalescing inside JSON.stringify Moves ?? fallbacks before serialization to eliminate dead code in generated virtual module. Fixes esbuild suspicious-nullish-coalescing warning. * chore: add changeset * Attempt to reduce falkiness in view transition e2e tests (#15142) * Attempt to reduce falkiness in view transition e2e tests * try wait for idle state * next try * Update view-transitions.test.js * [ci] format * fix(toolbar): skip image audit for framework components (#15149) * fix(toolbar): skip image audit for framework components Images inside astro-island elements (React, Vue, Svelte, etc. with client:* directives) now skip the 'Use the Image component' audit warning, since these components can't directly use Astro's Image component. Fixes #15048 * test: remove unused image * test: use smaller test image (22KB instead of 253KB) * fix: Accept setCookie from both context and headers (#15152) Co-authored-by: Florian Lefebvre <[email protected]> * [ci] release (#15132) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix(ci): Move ts-plugin-bundle to node_modules after recreating node_modules (#15156) * fix(ci): Move ts-plugin-bundle to node_modules after recreating node_modules * fix: make itw ork in dev * chore: changeset * [ci] release (#15158) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: scripts not rendering with unused Fragment slots (#13847) (#15147) * Fix hydration for framework components in MDX slots (#15150) * Fix hydration for framework components in MDX slots using Astro.slots.render() * Update packages/astro/src/runtime/server/render/slot.ts Co-authored-by: Luiz Ferraz <[email protected]> --------- Co-authored-by: Luiz Ferraz <[email protected]> * [ci] format * Fixes build * fix: apply trailing slash query params fix to new architecture Port fix from #15124 to vite-plugin-app/app.ts --------- Co-authored-by: Erika <[email protected]> Co-authored-by: Antony Faris <[email protected]> Co-authored-by: Erika <[email protected]> Co-authored-by: Florian Lefebvre <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Chris Swithinbank <[email protected]> Co-authored-by: Houston (Bot) <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Emanuele Stoppa <[email protected]> Co-authored-by: Matt Kane <[email protected]> Co-authored-by: Florian Lefebvre <[email protected]> Co-authored-by: Volpeon <[email protected]> Co-authored-by: Martin Trapp <[email protected]> Co-authored-by: fkatsuhiro <[email protected]> Co-authored-by: Oliver Speir <[email protected]> Co-authored-by: Andreas Deininger <[email protected]> Co-authored-by: Roman <[email protected]> Co-authored-by: fabon <[email protected]> Co-authored-by: Raanelom <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: Rahul Dogra <[email protected]> Co-authored-by: Armand Philippot <[email protected]> Co-authored-by: James Garbutt <[email protected]> Co-authored-by: matthewp <[email protected]> Co-authored-by: florian-lefebvre <[email protected]> Co-authored-by: ematipico <[email protected]> Co-authored-by: Pegasus <[email protected]> Co-authored-by: Cameron Smith <[email protected]> Co-authored-by: Martin Trapp <[email protected]> Co-authored-by: Rafael ヤスヒデ 須藤 <[email protected]> Co-authored-by: Luiz Ferraz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Moving e2e tests to Firefox 144 showed a race condition on the order in which animations are canceled when a view transition get aborted. The fix makes the animation names indistinguishable in the test output, ensuring that the order does not matter.
A second test tested fallback behavior for browsers that do not support view transitions.
Skipped that one as we do not have such browsers in our playwright setup anymore
(and also won't suggest to add one)
Testing
right.
Docs
n.a.