-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Gallery Refactor] Analytics #16848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gallery Refactor] Analytics #16848
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
@antonis I added a property to the |
I totally agree with that Chip. We better have this information available even if we don't use it. |
0afd6f9 to
c574988
Compare
|
You can trigger an installable build for these changes by visiting CircleCI here. |
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @chipsnyder 👍
The code LGTM and the app works as expected 🎉
|
Merging this into the base branch as a landing spot before moving to |
c5cfebd
into
rnmobile/refactor/gallery-as-nested-image-blocks-editor-settings_v2
Description
This adds the results of the
unstableGalleryWithImageBlockssetting to theeditor_session_startevent so that we can monitor how many of our users have migrated to the new gallery refactor over time.This builds off of #16832
To test:
Setup
Enable Gallery Refactor
editor_session_startcontain the propertyunstableGalleryWithImageBlockswith the valuetrueDisable Gallery Refactor
editor_session_startcontain the propertyunstableGalleryWithImageBlockswith the valuefalseRegression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.