Skip to content

Conversation

@chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Jul 12, 2021

Description

This adds the results of the unstableGalleryWithImageBlocks setting to the editor_session_start event so that we can monitor how many of our users have migrated to the new gallery refactor over time.

This builds off of #16832

To test:

Setup

  1. A site running Gutenberg generated from [Mobile] Pass the Gallery v2 Flag over from the editor WordPress/gutenberg#33314. You can use wp-env start or generate a new bundle.
  2. On your site enable the Gallery Refactor by going to Gutenberg > Experminents > Check "Gallery Refactor"

Enable Gallery Refactor

  1. Navigate to the Editor
  2. Expect to see the event editor_session_start contain the property unstableGalleryWithImageBlocks with the value true

Disable Gallery Refactor

  1. Navigate to the Editor
  2. Expect to see the event editor_session_start contain the property unstableGalleryWithImageBlocks with the value false

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder added [Type] Enhancement Analytics [Status] Needs Discussion The issue needs to be discussed by the team before it can be resolved. labels Jul 12, 2021
@chipsnyder chipsnyder requested a review from antonis July 12, 2021 20:00
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 12, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 12, 2021

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@chipsnyder
Copy link
Contributor Author

@antonis I added a property to the editor_session_start so that we can report on the use of Gallery v2. I'm only 50/50 on this one though but I thought it's better to have it and not use it than need it and not have it. Let me know your thoughts.

@antonis
Copy link

antonis commented Jul 13, 2021

@antonis I added a property to the editor_session_start so that we can report on the use of Gallery v2. I'm only 50/50 on this one though but I thought it's better to have it and not use it than need it and not have it. Let me know your thoughts.

I totally agree with that Chip. We better have this information available even if we don't use it.
The code changes LGTM btw. I'll get back to this to fully test the PR.

@chipsnyder chipsnyder marked this pull request as ready for review August 2, 2021 20:41
@chipsnyder chipsnyder force-pushed the rnmobile/refactor/gallery_analytics branch from 0afd6f9 to c574988 Compare August 2, 2021 20:42
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @chipsnyder 👍
The code LGTM and the app works as expected 🎉

@chipsnyder
Copy link
Contributor Author

Merging this into the base branch as a landing spot before moving to develop

@chipsnyder chipsnyder merged commit c5cfebd into rnmobile/refactor/gallery-as-nested-image-blocks-editor-settings_v2 Aug 4, 2021
@chipsnyder chipsnyder deleted the rnmobile/refactor/gallery_analytics branch August 4, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Analytics [Status] Needs Discussion The issue needs to be discussed by the team before it can be resolved. [Type] Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants