Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented May 12, 2022

Fixes #16506

Depends on: #16510

Description

This PR randomises the order of the designs shown for categories. The recommended designs area does not use random ordering unless the Blog category fallback is recommended.

To test:

To fully test this PR the group field (ref D80005) and recommended designs (ref D80579) should be available on the backend or sandbox.

Vertical with recommendations selected

  1. Start the site creation flow
  2. Select on of the six initial/default verticals that have associated recommended designs
  3. Verify that the recommended designs are suggested at the top
  4. Verify that the recommended designs are not shuffled (keep the api order)
  5. Verify that the order of the designs in the other categories is random

Vertical selection skipped

  1. Start the site creation flow
  2. Skip the vertical selection
  3. Verify that the blog category is recommended at the top
  4. Verify that the order of the designs in the all categories is random

Vertical has no recommendations

  1. Start the site creation flow
  2. Select a vertical that is not one of the initial/default verticals or enter a custom vertical
  3. Verify that the blog category is recommended at the top
  4. Verify that the order of the designs in the all categories is random

Regression

  1. Tap the ➕ button on the My site screen
  2. Select Site page
  3. Verify that the order of the layouts unchanged (not random)

Regression Notes

  1. Potential unintended areas of impact
    Page layout picker

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Relied on existing test

  3. What automated tests I added (or what prevented me from doing so)
    Extended tests in SiteDesignRecommendationProviderTest

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@antonis antonis added [Type] Task Site Creation Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. labels May 12, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 12, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 12, 2022

You can test the changes on this Pull Request by downloading the APKs:

@antonis antonis marked this pull request as ready for review May 12, 2022 11:20
@antonis antonis requested a review from a team May 12, 2022 11:21
Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, it works as expected 🎉

:shipit:

@ovitrif ovitrif merged commit 1020c4d into task/16503-recommend-vertical-designs May 13, 2022
@ovitrif ovitrif deleted the task/16506-randomise-designs-order branch May 13, 2022 09:45
@antonis antonis mentioned this pull request May 24, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. Site Creation [Type] Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants