-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Site Design Revamp] Randomize order of designs for categories #16531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ovitrif
merged 7 commits into
task/16503-recommend-vertical-designs
from
task/16506-randomise-designs-order
May 13, 2022
Merged
[Site Design Revamp] Randomize order of designs for categories #16531
ovitrif
merged 7 commits into
task/16503-recommend-vertical-designs
from
task/16506-randomise-designs-order
May 13, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
3 tasks
…randomise-designs-order
…randomise-designs-order
ovitrif
approved these changes
May 13, 2022
Contributor
ovitrif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, it works as expected 🎉
![]()
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Part of a WIP Feature
This label is used to disable milestone checks for PRs that are not against `develop` or `release`.
Site Creation
[Type] Task
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16506
Depends on: #16510
Description
This PR randomises the order of the designs shown for categories. The recommended designs area does not use random ordering unless the Blog category fallback is recommended.
To test:
To fully test this PR the
groupfield (refD80005) and recommended designs (refD80579) should be available on the backend or sandbox.Vertical with recommendations selected
Vertical selection skipped
Vertical has no recommendations
Regression
Regression Notes
Potential unintended areas of impact
Page layout picker
What I did to test those areas of impact (or what existing automated tests I relied on)
Relied on existing test
What automated tests I added (or what prevented me from doing so)
Extended tests in
SiteDesignRecommendationProviderTestPR submission checklist:
RELEASE-NOTES.txtif necessary.