[Site Design Revamp] Recommends designs based on chosen vertical #16510

antonis · 2022-05-10T09:54:35Z

Description

This PR determines recommended designs based on chosen vertical according to the following logic:

when no vertical is selected the blog category is recommended
when a vertical is selected and there are no recommendations, the blog category is recommended
when a vertical is selected and there are recommendations, a recommended category is created
when no vertical is selected and there is no blog category skip the recommendation
when a vertical is selected and there are no recommendations or blog category skip the recommendation

Note:
The randomisation of the recommended blog category order will be handled separately

To test:

To fully test this PR the group field (ref D80005) and recommended designs (ref D80579) should be available on the backend or sandbox.

Vertical with recommendations selected

Start the site creation flow
Select on of the six initial/default verticals that have associated recommended designs
Verify that the recommended designs are suggested at the top

Vertical selection skipped

Start the site creation flow
Skip the vertical selection
Verify that the blog category is recommended at the top

Vertical has no recommendations

Start the site creation flow
Select a vertical that is not one of the initial/default verticals or enter a custom vertical
Verify that the blog category is recommended at the top

Regression Notes

Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
Relied on existing test
What automated tests I added (or what prevented me from doing so)
Added tests for the recommendation logic in SiteDesignRecommendationProviderTest

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…ertical-designs

peril-wordpress-mobile · 2022-05-10T09:54:41Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

peril-wordpress-mobile · 2022-05-10T10:14:29Z

You can test the changes on this Pull Request by downloading the APKs:

Jetpack-pr-16510-build-123389.apk

WordPress-pr-16510-build-123389.apk

build.gradle

antonis · 2022-05-10T14:54:23Z

Leaving this in draft state till it can be tested with the backend

…egories

ovitrif · 2022-05-12T10:35:22Z

Leaving this in draft state till it can be tested with the backend

I've tested it by merging locally the pending changes to the backend and it works as expected: p1652300714807109-slack-C03CVCCN3J5

I guess we need the changes to be merged on the backend before actually merging this

…ertical-designs # Conflicts: # build.gradle

…randomise-designs-order

antonis · 2022-05-12T10:58:01Z

Thank you for testing @ovitrif 🙇

I guess we need the changes to be merged on the backend before actually merging this

To fully test this PR the group field (ref D80005) and recommended designs (ref D80579) should be available on the backend or sandbox. On the other hand since this won't reach trunk yet, we can merge it. I updated the description to reflect that and made changed it to Ready for Review.

…randomise-designs-order

antonis · 2022-05-12T14:37:01Z

WordPress/src/main/java/org/wordpress/android/ui/sitecreation/theme/HomePagePickerViewModel.kt

    fun onChooseTapped() {
-        // TODO: adapt this to the new flow
        selectedLayout?.let { layout ->
+            super.onPreviewChooseTapped()


@mkevins Delaying the super call that dismisses the preview screen and unselects the layout seems to fix the flow.
I removed the TODO but I'll be happy to put it back if there is more to it 🙏

Fwiw, I added this comment before removing the bottom action buttons, and I left it in case anything else would need to be wired up when adding the new behavior. Delaying it sounds good to me (an alternative might be to pass it as a parameter, but I think this is simpler 🤷‍♂️ ).

One other consideration I had at the time was with regard to the tracks events, and whether we are differentiating between the user choosing from the main screen and the preview screen (in the old flow). In the new flow there is only one path to choose a theme, so maybe we just need to update the tracks description to reflect this?

Thank you for the feedback @mkevins 🙇

One other consideration I had at the time was with regard to the tracks events, and whether we are differentiating between the user choosing from the main screen and the preview screen (in the old flow). In the new flow there is only one path to choose a theme, so maybe we just need to update the tracks description to reflect this?

That's a good point. I think with the old flow we do not differentiate between choosing directly or choosing in the preview screen and emit the same event enhanced_site_creation_site_design_selected. Despite that I think it's a good idea to make clear in the description of what we track when we update it to add the new recommended property.

ps. I added a draft issue [Site Design Revamp] Update Tracks event (non-blocking) on the board (cc @twstokes)

…elected event

…ertical-designs

…randomise-designs-order

…track-recommended-property

ovitrif

Great work @antonis, thank you for tackling this 🙇

✅ The code LGTM
✅ Following the test steps results works as described
🔴 I might have found a bug while doing exploratory testing:

Tap back, pick another vertical → the recommended section doesn't update:

It's the same when using the skip button. It might be something related to how it works when the ViewModel already exists in memory.

Not sure if we want to fix it before merging to the feature branch or afterwards 🤷‍♂️

…designs-order [Site Design Revamp] Randomize order of designs for categories

antonis · 2022-05-13T09:49:19Z

Thank you for testing @ovitrif 🙇

I might have found a bug while doing exploratory testing:
Good catch 👍
Not sure if we want to fix it before merging to the feature branch or afterwards 🤷‍♂️
I'll have a look later today 🤞 In any case we can merge and open a bug on the project to be handled separately.

ovitrif · 2022-05-13T09:54:34Z

Thank you for testing @ovitrif 🙇

I might have found a bug while doing exploratory testing:

Good catch 👍
Not sure if we want to fix it before merging to the feature branch or afterwards 🤷‍♂️
I'll have a look later today 🤞 In any case we can merge and open a bug on the project to be handled separately.

Let's merge this since the issue can be tackled separately.

Going to review the other PR that depends on this: #16538

…mmended-property [Site Design Revamp] Send recommended property with Tracks event on design selection

ovitrif

I created this issue for the bug we identified: #16540.

Planning to merge this one @antonis

antonis · 2022-05-13T14:10:41Z

I created this issue for the bug we identified: #16540.

Thank you for merging and opening the issue @ovitrif 🙇

antonis added 4 commits May 10, 2022 12:40

Updates FluxC reference

f502a2a

Pass selected vertical to the design picker

a6f506f

Recommend designs based on the selected vertical

85d9074

Merge branch 'feature/site-design-revamp' into task/16503-recommend-v…

7142471

…ertical-designs

antonis changed the base branch from trunk to feature/site-design-revamp May 10, 2022 09:55

antonis added [Type] Task Site Creation Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. labels May 10, 2022

This was referenced May 10, 2022

Adds group field in the starter designs response wordpress-mobile/WordPress-FluxC-Android#2385

Merged

Adds group field in the starter designs response #16509

Merged

antonis added the [Status] Not Ready for Review label May 10, 2022

antonis added 2 commits May 10, 2022 17:27

Extracts the recommendation logic to a separate file

9677bb9

Tests the recommended designs logic

fe387f4

antonis commented May 10, 2022

View reviewed changes

build.gradle Outdated Show resolved Hide resolved

antonis added [Status] Not Ready for Merge and removed [Status] Not Ready for Review labels May 10, 2022

antonis added 2 commits May 12, 2022 09:55

Adds a mechanism for randomising the order of layouts in specific cat…

0052838

…egories

Randomises the order of site designs except for the recommended category

29060b9

antonis mentioned this pull request May 12, 2022

[Site Design Revamp] Randomize order of designs for categories #16531

Merged

3 tasks

antonis added 2 commits May 12, 2022 10:12

Also save the ordered layouts per category for efficiency

69d9798

Unit tests for which categories should be randomised

9daa723

antonis added 2 commits May 12, 2022 13:41

Merge branch 'feature/site-design-revamp' into task/16503-recommend-v…

c349fca

…ertical-designs # Conflicts: # build.gradle

Merge branch 'task/16503-recommend-vertical-designs' into task/16506-…

11ff1a1

…randomise-designs-order

antonis added [Type] Enhancement and removed [Type] Enhancement [Status] Not Ready for Merge labels May 12, 2022

antonis marked this pull request as ready for review May 12, 2022 10:58

antonis requested a review from a team May 12, 2022 10:59

antonis added 2 commits May 12, 2022 17:31

Unselect the layout after the choose action if fired

e0980a7

Merge branch 'task/16503-recommend-vertical-designs' into task/16506-…

2fa545a

…randomise-designs-order

antonis commented May 12, 2022

View reviewed changes

antonis mentioned this pull request May 13, 2022

[Site Design Revamp] Send recommended property with Tracks event on design selection #16538

Merged

3 tasks

antonis added 4 commits May 13, 2022 07:47

Adds recommended property in the enhanced_site_creation_site_design_s…

3ddba5e

…elected event

Merge branch 'feature/site-design-revamp' into task/16503-recommend-v…

e80ad38

…ertical-designs

Merge branch 'task/16503-recommend-vertical-designs' into task/16506-…

319e4c5

…randomise-designs-order

Merge branch 'task/16503-recommend-vertical-designs' into task/16528-…

62812e7

…track-recommended-property

antonis added [Type] Enhancement and removed [Type] Enhancement labels May 13, 2022

Hides keyboard on back

91c1cab

ovitrif reviewed May 13, 2022

View reviewed changes

Merge pull request #16531 from wordpress-mobile/task/16506-randomise-…

1020c4d

…designs-order [Site Design Revamp] Randomize order of designs for categories

antonis added [Type] Enhancement and removed [Type] Enhancement labels May 13, 2022

Merge pull request #16538 from wordpress-mobile/task/16528-track-reco…

8a16b16

…mmended-property [Site Design Revamp] Send recommended property with Tracks event on design selection

ovitrif added [Type] Enhancement and removed [Type] Enhancement labels May 13, 2022

ovitrif approved these changes May 13, 2022

View reviewed changes

ovitrif mentioned this pull request May 13, 2022

[Site Design Revamp] Going back from Site Theme screen and selecting another topic doesn't update the recommended section #16540

Closed

ovitrif merged commit 7f12781 into feature/site-design-revamp May 13, 2022

ovitrif deleted the task/16503-recommend-vertical-designs branch May 13, 2022 10:46

antonis mentioned this pull request May 24, 2022

Site Design Screen Improvements #16468

Merged

3 tasks

[Site Design Revamp] Recommends designs based on chosen vertical #16510

[Site Design Revamp] Recommends designs based on chosen vertical #16510

Uh oh!

Conversation

antonis commented May 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

To test:

Vertical with recommendations selected

Vertical selection skipped

Vertical has no recommendations

Regression Notes

Uh oh!

peril-wordpress-mobile bot commented May 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented May 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

antonis commented May 10, 2022

Uh oh!

ovitrif commented May 12, 2022

Uh oh!

antonis commented May 12, 2022

Uh oh!

antonis May 12, 2022

Choose a reason for hiding this comment

Uh oh!

mkevins May 15, 2022

Choose a reason for hiding this comment

Uh oh!

antonis May 16, 2022

Choose a reason for hiding this comment

Uh oh!

ovitrif left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

antonis commented May 13, 2022

Uh oh!

ovitrif commented May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ovitrif left a comment

Choose a reason for hiding this comment

Uh oh!

antonis commented May 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

antonis commented May 10, 2022 •

edited

Loading

peril-wordpress-mobile bot commented May 10, 2022 •

edited

Loading

peril-wordpress-mobile bot commented May 10, 2022 •

edited

Loading

ovitrif left a comment •

edited

Loading

ovitrif commented May 13, 2022 •

edited

Loading